Prepending "Get" when type with conflicting name is hidden inside return type.

tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gen/thing.h"
 
 namespace v8 {
 
 class InterfaceOutsideOfBlink {
  public:
@@ skipping 163 matching lines @@
 struct StructInBlink {
   // Structs in blink should rename their methods to capitals.
   bool function() { return true; }
 };
 
 class BitVector {
  public:
   class OutOfLineBits {};
   enum Foo { Blah };
   struct Bar {};
+  class Baz {};
+
+  template <typename T>
+  class MyRefPtr {};
 
   // Naive renaming will break the build, by leaving return type the same
-  // as method the name - to avoid this "Get" prefix needs to be prepended
+  // as the method name - to avoid this "Get" prefix needs to be prepended
   // as suggested in https://crbug.com/582312#c17.
   const OutOfLineBits* outOfLineBits() const { return nullptr; }
   Foo foo() { return Blah; }
   const Bar& bar() const { return m_bar; }
+  MyRefPtr<Baz> baz() { return MyRefPtr<Baz>(); }

[danakj, 2016/09/08 23:30:40]

does it work for "const MyRefPtr<Baz>&" also? add testcase?

[Łukasz Anforowicz, 2016/09/09 00:20:35]

It works.  I've added a test.

 
  private:
   Bar m_bar;
 };
 
 }  // namespace blink
 
 namespace WTF {
 
 struct StructInWTF {
@@ skipping 24 matching lines @@
   static void method();
 };
 
 }  // namespace internal
 
 }  // namespace blink
 
 // https://crbug.com/640688 - need to rewrite method name below.
 void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {}
 void blink::internal::InternalClass::method() {}