Prepending "Get" when type with conflicting name is hidden inside return type.

tools/clang/rewrite_to_chrome_style/tests/functions-original.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 namespace blink {
 
+namespace {
+
+// Naive renaming will break the build, by leaving return type the same name as
+// the function name - to avoid this "Get" prefix needs to be prepended as
+// suggested in https://crbug.com/582312#c17.
+class Foo582312 {};
+using Bar = Foo582312;
+static Bar* bar() {
+  return nullptr;
+}
+}

[danakj, 2016/09/08 23:30:40]

nit: whitespace above and // namespace

[Łukasz Anforowicz, 2016/09/09 00:20:35]

Done.

+
 // Tests that the prototype for a function is updated.
 int testFunctionThatTakesTwoInts(int x, int y);
 // Overload to test using declarations that introduce multiple shadow
 // declarations.
 int testFunctionThatTakesTwoInts(int x, int y, int z);
 
 // Test that the actual function definition is also updated.
 int testFunctionThatTakesTwoInts(int x, int y) {
   if (x == 0)
     return y;
@@ skipping 29 matching lines @@
 }
 
 using blink::testFunctionThatTakesTwoInts;
 
 void G() {
   testFunctionThatTakesTwoInts(1, 2);
 
   blink::SwapType a, b;
   swap(a, b);
 }