Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Issue 2324633002: [DevTools] Turn remote modules into local with debug_devtools. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
chenwilliam, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Turn remote modules into local with debug_devtools. Currently, it's impossible to work on remote module as it tries to load source from the cloud. BUG=none Committed: https://crrev.com/181c7ad525a307e455a96adfe6c6301318024d85 Cr-Commit-Position: refs/heads/master@{#417158}

Patch Set 1 #

Patch Set 2 : another approach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
dgozman
Take a look please.
4 years, 3 months ago (2016-09-07 22:55:33 UTC) #2
chenwilliam
lgtm. this seems like a clean revert of the files I changed in https://codereview.chromium.org/2262743002/ re: ...
4 years, 3 months ago (2016-09-08 00:01:50 UTC) #4
dgozman
PTAL at new approach
4 years, 3 months ago (2016-09-08 00:28:01 UTC) #6
pfeldman
lgtm
4 years, 3 months ago (2016-09-08 00:33:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324633002/20001
4 years, 3 months ago (2016-09-08 00:34:10 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 01:55:03 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 01:57:25 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/181c7ad525a307e455a96adfe6c6301318024d85
Cr-Commit-Position: refs/heads/master@{#417158}

Powered by Google App Engine
This is Rietveld 408576698