Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 232463007: Don't leave aborted URLs in the omnibox unless we're on a new tab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 7be5f8c967940cc8bd780e2ab9f9313599f045c9..603bb288fc6dacd5189c4fd75fb222257db04d77 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -230,18 +230,31 @@ void NavigatorImpl::DidFailProvisionalLoadWithError(
// TODO(creis): Find a way to cancel any pending RFH here.
}
- // Do not usually clear the pending entry if one exists, so that the user's
- // typed URL is not lost when a navigation fails or is aborted. However, in
- // cases that we don't show the pending entry (e.g., renderer-initiated
- // navigations in an existing tab), we don't keep it around. That prevents
- // spoofs on in-page navigations that don't go through
+ // We usually clear the pending entry when it fails, so that an arbitrary URL
+ // isn't left visible above a committed page. This must be enforced when
+ // the pending entry isn't visible (e.g., renderer-initiated navigations) to
+ // prevent URL spoofs for in-page navigations that don't go through
// DidStartProvisionalLoadForFrame.
- // In general, we allow the view to clear the pending entry and typed URL if
- // the user requests (e.g., hitting Escape with focus in the address bar).
+ //
+ // However, we do preserve the pending entry in some cases, such as on the
+ // initial navigation of an unmodified blank tab. We also allow the delegate
+ // to say when it's safe to leave aborted URLs in the omnibox, to let the user
+ // edit the URL and try again. This may be useful in cases that the committed
+ // page cannot be attacker-controlled. In these cases, we still allow the
+ // view to clear the pending entry and typed URL if the user requests
+ // (e.g., hitting Escape with focus in the address bar).
+ //
// Note: don't touch the transient entry, since an interstitial may exist.
- if (controller_->GetPendingEntry() != controller_->GetVisibleEntry())
+ bool should_preserve_entry = controller_->IsUnmodifiedBlankTab() ||
+ delegate_->ShouldPreserveAbortedURLs();
+ if (controller_->GetPendingEntry() != controller_->GetVisibleEntry() ||
+ !should_preserve_entry) {
controller_->DiscardPendingEntry();
+ // Also force the UI to refresh.
+ controller_->delegate()->NotifyNavigationStateChanged(INVALIDATE_TYPE_URL);
+ }
+
if (delegate_)
delegate_->DidFailProvisionalLoadWithError(render_frame_host, params);
}
« no previous file with comments | « content/browser/frame_host/navigator_delegate.cc ('k') | content/browser/frame_host/render_frame_host_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698