Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 232463007: Don't leave aborted URLs in the omnibox unless we're on a new tab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix and add tests. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/debug/trace_event.h" 10 #include "base/debug/trace_event.h"
(...skipping 2327 matching lines...) Expand 10 before | Expand all | Expand 10 after
2338 FOR_EACH_OBSERVER(WebContentsObserver, observers_, 2338 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2339 DidOpenRequestedURL(new_contents, 2339 DidOpenRequestedURL(new_contents,
2340 params.url, 2340 params.url,
2341 params.referrer, 2341 params.referrer,
2342 params.disposition, 2342 params.disposition,
2343 params.transition, 2343 params.transition,
2344 source_render_frame_id)); 2344 source_render_frame_id));
2345 } 2345 }
2346 } 2346 }
2347 2347
2348 bool WebContentsImpl::ShouldPreserveAbortedURLs() {
2349 return delegate_->ShouldPreserveAbortedURLs(this);
2350 }
2351
2348 void WebContentsImpl::DidRedirectProvisionalLoad( 2352 void WebContentsImpl::DidRedirectProvisionalLoad(
2349 RenderFrameHostImpl* render_frame_host, 2353 RenderFrameHostImpl* render_frame_host,
2350 const GURL& validated_target_url) { 2354 const GURL& validated_target_url) {
2351 // Notify observers about the provisional change in the main frame URL. 2355 // Notify observers about the provisional change in the main frame URL.
2352 FOR_EACH_OBSERVER( 2356 FOR_EACH_OBSERVER(
2353 WebContentsObserver, 2357 WebContentsObserver,
2354 observers_, 2358 observers_,
2355 ProvisionalChangeToMainFrameUrl(validated_target_url, 2359 ProvisionalChangeToMainFrameUrl(validated_target_url,
2356 render_frame_host)); 2360 render_frame_host));
2357 } 2361 }
(...skipping 1479 matching lines...) Expand 10 before | Expand all | Expand 10 after
3837 3841
3838 void WebContentsImpl::OnPreferredSizeChanged(const gfx::Size& old_size) { 3842 void WebContentsImpl::OnPreferredSizeChanged(const gfx::Size& old_size) {
3839 if (!delegate_) 3843 if (!delegate_)
3840 return; 3844 return;
3841 const gfx::Size new_size = GetPreferredSize(); 3845 const gfx::Size new_size = GetPreferredSize();
3842 if (new_size != old_size) 3846 if (new_size != old_size)
3843 delegate_->UpdatePreferredSize(this, new_size); 3847 delegate_->UpdatePreferredSize(this, new_size);
3844 } 3848 }
3845 3849
3846 } // namespace content 3850 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698