Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 232463007: Don't leave aborted URLs in the omnibox unless we're on a new tab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix and add tests. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 virtual void TabReplacedAt(TabStripModel* tab_strip_model, 423 virtual void TabReplacedAt(TabStripModel* tab_strip_model,
424 content::WebContents* old_contents, 424 content::WebContents* old_contents,
425 content::WebContents* new_contents, 425 content::WebContents* new_contents,
426 int index) OVERRIDE; 426 int index) OVERRIDE;
427 virtual void TabPinnedStateChanged(content::WebContents* contents, 427 virtual void TabPinnedStateChanged(content::WebContents* contents,
428 int index) OVERRIDE; 428 int index) OVERRIDE;
429 virtual void TabStripEmpty() OVERRIDE; 429 virtual void TabStripEmpty() OVERRIDE;
430 430
431 // Overridden from content::WebContentsDelegate: 431 // Overridden from content::WebContentsDelegate:
432 virtual bool CanOverscrollContent() const OVERRIDE; 432 virtual bool CanOverscrollContent() const OVERRIDE;
433 virtual bool ShouldPreserveAbortedURLs(content::WebContents* source) OVERRIDE;
433 virtual bool PreHandleKeyboardEvent( 434 virtual bool PreHandleKeyboardEvent(
434 content::WebContents* source, 435 content::WebContents* source,
435 const content::NativeWebKeyboardEvent& event, 436 const content::NativeWebKeyboardEvent& event,
436 bool* is_keyboard_shortcut) OVERRIDE; 437 bool* is_keyboard_shortcut) OVERRIDE;
437 virtual void HandleKeyboardEvent( 438 virtual void HandleKeyboardEvent(
438 content::WebContents* source, 439 content::WebContents* source,
439 const content::NativeWebKeyboardEvent& event) OVERRIDE; 440 const content::NativeWebKeyboardEvent& event) OVERRIDE;
440 virtual void OverscrollUpdate(int delta_y) OVERRIDE; 441 virtual void OverscrollUpdate(int delta_y) OVERRIDE;
441 virtual void ShowValidationMessage(content::WebContents* web_contents, 442 virtual void ShowValidationMessage(content::WebContents* web_contents,
442 const gfx::Rect& anchor_in_root_view, 443 const gfx::Rect& anchor_in_root_view,
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
935 base::WeakPtrFactory<Browser> weak_factory_; 936 base::WeakPtrFactory<Browser> weak_factory_;
936 937
937 scoped_ptr<BrowserContentTranslateDriverObserver> translate_driver_observer_; 938 scoped_ptr<BrowserContentTranslateDriverObserver> translate_driver_observer_;
938 939
939 scoped_ptr<chrome::ValidationMessageBubble> validation_message_bubble_; 940 scoped_ptr<chrome::ValidationMessageBubble> validation_message_bubble_;
940 941
941 DISALLOW_COPY_AND_ASSIGN(Browser); 942 DISALLOW_COPY_AND_ASSIGN(Browser);
942 }; 943 };
943 944
944 #endif // CHROME_BROWSER_UI_BROWSER_H_ 945 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | content/browser/frame_host/navigation_controller_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698