Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2324623004: [heap] Fix a formatting bug in --trace-incremental-marking. (Closed)

Created:
4 years, 3 months ago by ulan
Modified:
4 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix a formatting bug in --trace-incremental-marking. BUG= Committed: https://crrev.com/212624b7570cd1c1cfad7cf958203b05af961637 Cr-Commit-Position: refs/heads/master@{#39278}

Patch Set 1 #

Patch Set 2 : add PRINTF_FORMAT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/heap/heap.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/isolate.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
ptal
4 years, 3 months ago (2016-09-08 11:06:33 UTC) #2
Michael Lippautz
lgtm
4 years, 3 months ago (2016-09-08 11:17:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324623004/20001
4 years, 3 months ago (2016-09-08 12:08:07 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 12:36:14 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/212624b7570cd1c1cfad7cf958203b05af961637 Cr-Commit-Position: refs/heads/master@{#39278}
4 years, 3 months ago (2016-09-08 12:36:43 UTC) #8
ulan
4 years, 3 months ago (2016-09-09 11:35:10 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2323293002/ by ulan@chromium.org.

The reason for reverting is: Revert to check if this is causing perf regressions
in crbug.com/645411.

Powered by Google App Engine
This is Rietveld 408576698