Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2324603002: Move AX local bounding box calculation into LayoutObject (Closed)

Created:
4 years, 3 months ago by dmazzoni
Modified:
4 years, 3 months ago
Reviewers:
chrishtr
CC:
aboxhall+watch_chromium.org, aboxhall, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dmazzoni, krit, dtseng+watch_chromium.org, eae+blinkwatch, Eric Willigers, f(malita), fs, gyuyoung2, haraken, jchaffraix+rendering, je_julie, kouhei+svg_chromium.org, leviw+renderwatch, nektar+watch_chromium.org, nektarios, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, szager+layoutwatch_chromium.org, yuzo+watch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move AX local bounding box calculation into LayoutObject Minor refactoring. Now that we've successfully switched to using relative bounding boxes in the accessibility tree, it's cleaner to have AXObject call a single interface on LayoutObject rather than calling different code depending on the type of LayoutObject. This will also help ensure this doesn't break the next time the layout code is refactored. This is covered by existing tests, in particular accessibility/bounds-calc.html tests a few examples of each of the four types of LayoutObject that need to implement this method. BUG=618120 Committed: https://crrev.com/64a061448438227cdd16d73d4d6944de6c5ddfd7 Cr-Commit-Position: refs/heads/master@{#417775}

Patch Set 1 #

Patch Set 2 : Fix LayoutInline #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -23 lines) Patch
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 2 2 chunks +1 line, -23 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dmazzoni
4 years, 3 months ago (2016-09-08 16:12:03 UTC) #3
chrishtr
lgtm
4 years, 3 months ago (2016-09-09 17:51:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324603002/40001
4 years, 3 months ago (2016-09-09 22:25:04 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-10 00:21:28 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 00:24:02 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/64a061448438227cdd16d73d4d6944de6c5ddfd7
Cr-Commit-Position: refs/heads/master@{#417775}

Powered by Google App Engine
This is Rietveld 408576698