[Mac] Fix for security indicator drag&drop navigation

chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h"
 
 #include <stddef.h>
 
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
@@ skipping 406 matching lines @@
   }
 
   // NOTE: This function must closely match the logic in
   // |-textFrameForFrame:|.
 
   // Superclass draws text portion WRT original |cellFrame|.
   ui::ScopedCGContextSmoothFonts fontSmoothing;
   [super drawInteriorWithFrame:cellFrame inView:controlView];
 }
 
+- (BOOL)canDropAtLocationInWindow:(NSPoint)location
+                           ofView:(AutocompleteTextField*)controlView {
+  NSRect cellFrame = [controlView bounds];
+  const BOOL flipped = [controlView isFlipped];
+  const NSPoint locationInView =
+      [controlView convertPoint:location fromView:nil];
+
+  // If we have decorations, the drop can't occur at their horizontal padding.
+  if (!leftDecorations_.empty()) {
+    NSRect leftPaddingFrame = cellFrame;
+    leftPaddingFrame.size.width = LeftDecorationXOffset();
+    if (NSMouseInRect(locationInView, leftPaddingFrame, flipped))

[shrike, 2016/09/16 18:28:41]

You could also just say if (locationInView.x < LeftDecorationXOffset())...

[spqchan, 2016/09/20 21:00:00]

Done.

+      return false;
+  }
+
+  if (!rightDecorations_.empty()) {

[shrike, 2016/09/16 18:28:41]

Do you think we really need this check? Seems like as long as locationInView.x
is beyond the first left decoration, it's OK to drop the URL?

[spqchan, 2016/09/20 21:00:00]

I think it's better to be consistent with the left and right sides

+    NSRect rightPaddingFrame = cellFrame;
+    rightPaddingFrame.origin.x = NSMaxX(cellFrame) - kRightDecorationXOffset;
+    rightPaddingFrame.size.width = kRightDecorationXOffset;
+    if (NSMouseInRect(locationInView, rightPaddingFrame, flipped))
+      return false;
+  }
+
+  LocationBarDecoration* decoration =
+      [self decorationForLocationInWindow:location
+                                   inRect:cellFrame
+                                   ofView:controlView];
+  return !decoration;
+}
+
 - (LocationBarDecoration*)decorationForEvent:(NSEvent*)theEvent
                                       inRect:(NSRect)cellFrame
                                       ofView:(AutocompleteTextField*)controlView
 {
+  return [self decorationForLocationInWindow:[theEvent locationInWindow]
+                                      inRect:cellFrame
+                                      ofView:controlView];
+}
+
+- (LocationBarDecoration*)decorationForLocationInWindow:(NSPoint)location
+                                                 inRect:(NSRect)cellFrame
+                                                 ofView:(AutocompleteTextField*)
+                                                            controlView {
   const BOOL flipped = [controlView isFlipped];
-  const NSPoint location =
-      [controlView convertPoint:[theEvent locationInWindow] fromView:nil];
+  const NSPoint locationInView =
+      [controlView convertPoint:location fromView:nil];
 
   std::vector<LocationBarDecoration*> decorations;
   std::vector<NSRect> decorationFrames;
   NSRect textFrame;
   CalculatePositionsInFrame(cellFrame, leftDecorations_, rightDecorations_,
                             &decorations, &decorationFrames, &textFrame);
 
   for (size_t i = 0; i < decorations.size(); ++i) {
-    if (NSMouseInRect(location, decorationFrames[i], flipped))
+    if (NSMouseInRect(locationInView, decorationFrames[i], flipped))
       return decorations[i];
   }
 
   return NULL;
 }
 
 - (NSMenu*)decorationMenuForEvent:(NSEvent*)theEvent
                            inRect:(NSRect)cellFrame
                            ofView:(AutocompleteTextField*)controlView {
   LocationBarDecoration* decoration =
@@ skipping 292 matching lines @@
 
 - (void)handleFocusEvent:(NSEvent*)event
                   ofView:(AutocompleteTextField*)controlView {
   if ([controlView observer]) {
     const bool controlDown = ([event modifierFlags] & NSControlKeyMask) != 0;
     [controlView observer]->OnSetFocus(controlDown);
   }
 }
 
 @end