Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2324573003:
DevTools: add devtools builder as CQ experiment (Closed)
|
Created:
4 years, 3 months ago by chenwilliam Modified:
4 years, 2 months ago Reviewers:
Sergiy Byelozyorov CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: add devtools builder as CQ experiment
I added a builder for devtools on tryserver.chromium.linux here:
https://codereview.chromium.org/2319213002/
I've tried a few builds for the builder on the tryserver
and it seems to be working OK:
https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools
BUG=642046
Committed: https://crrev.com/f755fc8d329167818a804a9225a32b9a389c5e50
Committed: https://crrev.com/58659ab4948e42c2ad11763bd3da735962cab400
Cr-Original-Commit-Position: refs/heads/master@{#417756}
Cr-Commit-Position: refs/heads/master@{#426581}
Patch Set 1 #
Messages
Total messages: 20 (9 generated)
Description was changed from ========== DevTools: add devtools builder as CQ experiment I added a builder for devtools on tryserver.chromium.linux here: https://codereview.chromium.org/2319213002/ The builder is working on Chromium FYI: https://build.chromium.org/p/chromium.fyi/builders/Chromium%20DevTools%20Linux/ BUG=642046 ========== to ========== DevTools: add devtools builder as CQ experiment I added a builder for devtools on tryserver.chromium.linux here: https://codereview.chromium.org/2319213002/ I've tried a few builds for the builder on the tryserver and it seems to be working OK: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools BUG=642046 ==========
chenwilliam@chromium.org changed reviewers: + sergiyb@chromium.org
PTAL. Do I need to request a master restart after a cq.cfg change? Thanks.
On 2016/09/09 17:37:02, chenwilliam wrote: > PTAL. Do I need to request a master restart after a cq.cfg change? Thanks. No. CQ should pick up the new config automatically.
lgtm
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: add devtools builder as CQ experiment I added a builder for devtools on tryserver.chromium.linux here: https://codereview.chromium.org/2319213002/ I've tried a few builds for the builder on the tryserver and it seems to be working OK: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools BUG=642046 ========== to ========== DevTools: add devtools builder as CQ experiment I added a builder for devtools on tryserver.chromium.linux here: https://codereview.chromium.org/2319213002/ I've tried a few builds for the builder on the tryserver and it seems to be working OK: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools BUG=642046 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: add devtools builder as CQ experiment I added a builder for devtools on tryserver.chromium.linux here: https://codereview.chromium.org/2319213002/ I've tried a few builds for the builder on the tryserver and it seems to be working OK: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools BUG=642046 ========== to ========== DevTools: add devtools builder as CQ experiment I added a builder for devtools on tryserver.chromium.linux here: https://codereview.chromium.org/2319213002/ I've tried a few builds for the builder on the tryserver and it seems to be working OK: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools BUG=642046 Committed: https://crrev.com/f755fc8d329167818a804a9225a32b9a389c5e50 Cr-Commit-Position: refs/heads/master@{#417756} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f755fc8d329167818a804a9225a32b9a389c5e50 Cr-Commit-Position: refs/heads/master@{#417756}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2350533002/ by chenwilliam@chromium.org. The reason for reverting is: No longer need devtools experiment..
Message was sent while issue was closed.
Description was changed from ========== DevTools: add devtools builder as CQ experiment I added a builder for devtools on tryserver.chromium.linux here: https://codereview.chromium.org/2319213002/ I've tried a few builds for the builder on the tryserver and it seems to be working OK: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools BUG=642046 Committed: https://crrev.com/f755fc8d329167818a804a9225a32b9a389c5e50 Cr-Commit-Position: refs/heads/master@{#417756} ========== to ========== DevTools: add devtools builder as CQ experiment I added a builder for devtools on tryserver.chromium.linux here: https://codereview.chromium.org/2319213002/ I've tried a few builds for the builder on the tryserver and it seems to be working OK: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools BUG=642046 Committed: https://crrev.com/f755fc8d329167818a804a9225a32b9a389c5e50 Cr-Commit-Position: refs/heads/master@{#417756} ==========
The CQ bit was checked by chenwilliam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: add devtools builder as CQ experiment I added a builder for devtools on tryserver.chromium.linux here: https://codereview.chromium.org/2319213002/ I've tried a few builds for the builder on the tryserver and it seems to be working OK: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools BUG=642046 Committed: https://crrev.com/f755fc8d329167818a804a9225a32b9a389c5e50 Cr-Commit-Position: refs/heads/master@{#417756} ========== to ========== DevTools: add devtools builder as CQ experiment I added a builder for devtools on tryserver.chromium.linux here: https://codereview.chromium.org/2319213002/ I've tried a few builds for the builder on the tryserver and it seems to be working OK: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools BUG=642046 Committed: https://crrev.com/f755fc8d329167818a804a9225a32b9a389c5e50 Cr-Commit-Position: refs/heads/master@{#417756} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: add devtools builder as CQ experiment I added a builder for devtools on tryserver.chromium.linux here: https://codereview.chromium.org/2319213002/ I've tried a few builds for the builder on the tryserver and it seems to be working OK: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools BUG=642046 Committed: https://crrev.com/f755fc8d329167818a804a9225a32b9a389c5e50 Cr-Commit-Position: refs/heads/master@{#417756} ========== to ========== DevTools: add devtools builder as CQ experiment I added a builder for devtools on tryserver.chromium.linux here: https://codereview.chromium.org/2319213002/ I've tried a few builds for the builder on the tryserver and it seems to be working OK: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_devtools BUG=642046 Committed: https://crrev.com/f755fc8d329167818a804a9225a32b9a389c5e50 Committed: https://crrev.com/58659ab4948e42c2ad11763bd3da735962cab400 Cr-Original-Commit-Position: refs/heads/master@{#417756} Cr-Commit-Position: refs/heads/master@{#426581} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/58659ab4948e42c2ad11763bd3da735962cab400 Cr-Commit-Position: refs/heads/master@{#426581}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2458463002/ by chenwilliam@chromium.org. The reason for reverting is: No longer need CQ experiment. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
