Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2324573002: GN: do not set default GN args (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: do not set default GN args It's just visual noise... this should make future gn_flavor.py changes show fewer incidental diffs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324573002 Committed: https://skia.googlesource.com/skia/+/34ffb342f53cbc1f5951cd175ecc134e21ff0e20

Patch Set 1 #

Patch Set 2 : is_debug too #

Messages

Total messages: 18 (13 generated)
mtklein_C
4 years, 3 months ago (2016-09-07 21:10:31 UTC) #7
mtklein
ping?
4 years, 3 months ago (2016-09-08 13:43:28 UTC) #13
jcgregorio
lgtm
4 years, 3 months ago (2016-09-08 13:46:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324573002/20001
4 years, 3 months ago (2016-09-08 13:48:10 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 13:49:08 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/34ffb342f53cbc1f5951cd175ecc134e21ff0e20

Powered by Google App Engine
This is Rietveld 408576698