Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2324553003:
Try to get clang upload script working on Windows. (Closed)
DescriptionTry to get clang upload script working on Windows.
BUG=
Committed: https://crrev.com/0104c973f2c59a7a66b116b4f75e87b5b85f2dff
Cr-Commit-Position: refs/heads/master@{#417106}
Patch Set 1 #
Total comments: 4
Patch Set 2 : newlines #
Total comments: 2
Patch Set 3 : scottmg #Patch Set 4 : tweak #Messages
Total messages: 17 (6 generated)
thakis@chromium.org changed reviewers: + hans@chromium.org, scottmg@chromium.org
First to review wins!
lgtm
lgtm https://codereview.chromium.org/2324553003/diff/1/tools/clang/scripts/upload_... File tools/clang/scripts/upload_revision.py (right): https://codereview.chromium.org/2324553003/diff/1/tools/clang/scripts/upload_... tools/clang/scripts/upload_revision.py:42: is_win = sys.platform.startswith('win32') Maybe make is_win (or IS_WIN) a global. https://codereview.chromium.org/2324553003/diff/1/tools/clang/scripts/upload_... tools/clang/scripts/upload_revision.py:43: # Needs shell=True on Windows due to gn.bat in depot_tools. ...due to git.bat...
Thanks! Patch set 2 makes it so that it also doesn't put dos-style line endings everywhere.
https://codereview.chromium.org/2324553003/diff/1/tools/clang/scripts/upload_... File tools/clang/scripts/upload_revision.py (right): https://codereview.chromium.org/2324553003/diff/1/tools/clang/scripts/upload_... tools/clang/scripts/upload_revision.py:42: is_win = sys.platform.startswith('win32') On 2016/09/07 22:00:45, scottmg wrote: > Maybe make is_win (or IS_WIN) a global. Done. https://codereview.chromium.org/2324553003/diff/1/tools/clang/scripts/upload_... tools/clang/scripts/upload_revision.py:43: # Needs shell=True on Windows due to gn.bat in depot_tools. On 2016/09/07 22:00:45, scottmg wrote: > ...due to git.bat... Done.
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hans@chromium.org, scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2324553003/#ps40001 (title: "scottmg")
https://codereview.chromium.org/2324553003/diff/20001/tools/clang/scripts/upl... File tools/clang/scripts/upload_revision.py (right): https://codereview.chromium.org/2324553003/diff/20001/tools/clang/scripts/upl... tools/clang/scripts/upload_revision.py:26: with open(UPDATE_PY_PATH, 'r') as f: rb here then too?
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2324553003/diff/20001/tools/clang/scripts/upl... File tools/clang/scripts/upload_revision.py (right): https://codereview.chromium.org/2324553003/diff/20001/tools/clang/scripts/upl... tools/clang/scripts/upload_revision.py:26: with open(UPDATE_PY_PATH, 'r') as f: On 2016/09/07 22:02:29, scottmg wrote: > rb here then too? Hm, seems to work as-is as well, but changing it here too is nicer. Done.
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hans@chromium.org, scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2324553003/#ps60001 (title: "tweak")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Try to get clang upload script working on Windows. BUG= ========== to ========== Try to get clang upload script working on Windows. BUG= Committed: https://crrev.com/0104c973f2c59a7a66b116b4f75e87b5b85f2dff Cr-Commit-Position: refs/heads/master@{#417106} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0104c973f2c59a7a66b116b4f75e87b5b85f2dff Cr-Commit-Position: refs/heads/master@{#417106} |
