Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2324533002: [Chromecast] Fix fade-out frames in ALSA mixer (Closed)

Created:
4 years, 3 months ago by kmackay
Modified:
4 years, 3 months ago
Reviewers:
slan, halliwell
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Fix fade-out frames in ALSA mixer The fade-out frames were being calculated with the input sample rate instead of the output sample rate. Also updated the logging to make debugging easier. BUG= Committed: https://crrev.com/baca89c13a0c39d5b3d5ce17f1f93d06abceb471 Cr-Commit-Position: refs/heads/master@{#417063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.cc View 10 chunks +25 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kmackay
4 years, 3 months ago (2016-09-07 19:07:14 UTC) #2
halliwell
On 2016/09/07 19:07:14, kmackay wrote: lgtm, just remove gerrit change-id
4 years, 3 months ago (2016-09-07 20:53:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324533002/1
4 years, 3 months ago (2016-09-07 21:06:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 21:54:17 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 21:57:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/baca89c13a0c39d5b3d5ce17f1f93d06abceb471
Cr-Commit-Position: refs/heads/master@{#417063}

Powered by Google App Engine
This is Rietveld 408576698