Add logic to cache elements of panner node from calculation with own attributes and AudioListener

Source/modules/webaudio/AudioListener.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 14 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 
 #if ENABLE(WEB_AUDIO)
 
 #include "modules/webaudio/AudioListener.h"
 
+#include "modules/webaudio/PannerNode.h"

[Raymond Toy, 2014/04/16 17:36:15]

Is this necessary?

[KhNo, 2014/04/17 13:41:03]

Yes, it is for m_panners[i]->updatePannerDirty(type);

 #include "platform/audio/AudioBus.h"
 
 namespace WebCore {
 
 AudioListener::AudioListener()
     : m_position(0, 0, 0)
     , m_orientation(0, 0, -1)
     , m_upVector(0, 1, 0)
     , m_velocity(0, 0, 0)
     , m_dopplerFactor(1)
     , m_speedOfSound(343.3)
 {
     ScriptWrappable::init(this);
 }
 
+AudioListener::~AudioListener()
+{
+    m_panners.clear();
+}
+
+void AudioListener::addPanner(PannerNode* panner)
+{
+    if (!panner)
+        return;
+
+    m_panners.append(panner);
+}
+
+void AudioListener::removePanner(PannerNode* panner)
+{
+    for (unsigned i = 0; i < m_panners.size(); ++i) {
+        if (panner == m_panners[i]) {
+            m_panners.remove(i);
+            break;
+        }
+    }
+}
+
+void AudioListener::updatePannersDirty(unsigned type)

[Raymond Toy, 2014/04/16 17:36:15]

I think updateDirtyPanners is a better name.

[KhNo, 2014/04/17 13:41:03]

Changed to markPannersAsDirty

+{
+    for (unsigned i = 0; i < m_panners.size(); ++i)
+        m_panners[i]->updatePannerDirty(type);
+}
+
+void AudioListener::setPosition(const FloatPoint3D &position)
+{
+    if (m_position == position)
+        return;
+
+    // This synchronizes with panner's process().
+    MutexLocker listenerLocker(m_listenerLock);
+    m_position = position;
+    updatePannersDirty(PannerNode::AzimuthElevationDirty | PannerNode::DistanceConeGainDirty | PannerNode::DopplerRateDirty);

[Raymond Toy, 2014/04/16 17:36:15]

udpatePannersDirty is protected by m_processLock (panner) and m_listenerLock. 
Any possibility of deadlock?

Would it be possible to use the PannerNode's process lock for this instead of
the separate m_listenerLock?

[KhNo, 2014/04/17 13:41:03]

Actually, I have tried to using pannerNode's process lock.
In case of multiple panners, when one of parameter has changed in AudioListener,
all pannerNodes should be locked since what panner's process() is running in
audio thread.
In addition, it should marked dirty of all panners.

There is no deadlock.
AudioListener's main thread is lock only listenerlock to set true.
Panner's main thread is lock only processlock to set true.
Audiothread is trylock both locks to set false.

+}
+
+void AudioListener::setOrientation(const FloatPoint3D &orientation)
+{
+    if (m_orientation == orientation)
+        return;
+
+    // This synchronizes with panner's process().
+    MutexLocker listenerLocker(m_listenerLock);
+    m_orientation = orientation;
+    updatePannersDirty(PannerNode::AzimuthElevationDirty);
+}
+
+void AudioListener::setUpVector(const FloatPoint3D &upVector)
+{
+    if (m_upVector == upVector)
+        return;
+
+    // This synchronizes with panner's process().
+    MutexLocker listenerLocker(m_listenerLock);
+    m_upVector = upVector;
+    updatePannersDirty(PannerNode::AzimuthElevationDirty);
+}
+
+void AudioListener::setVelocity(const FloatPoint3D &velocity)
+{
+    if (m_velocity == velocity)
+        return;
+
+    // This synchronizes with panner's process().
+    MutexLocker listenerLocker(m_listenerLock);
+    m_velocity = velocity;
+    updatePannersDirty(PannerNode::DopplerRateDirty);
+}
+
+void AudioListener::setDopplerFactor(double dopplerFactor)
+{
+    if (m_dopplerFactor == dopplerFactor)
+        return;
+
+    // This synchronizes with panner's process().
+    MutexLocker listenerLocker(m_listenerLock);
+    m_dopplerFactor = dopplerFactor;
+    updatePannersDirty(PannerNode::DopplerRateDirty);
+}
+
+void AudioListener::setSpeedOfSound(double speedOfSound)
+{
+    if (m_speedOfSound == speedOfSound)
+        return;
+
+    // This synchronizes with panner's process().
+    MutexLocker listenerLocker(m_listenerLock);
+    m_speedOfSound = speedOfSound;
+    updatePannersDirty(PannerNode::DopplerRateDirty);
+}
+
 } // namespace WebCore
 
 #endif // ENABLE(WEB_AUDIO)