Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

Issue 2324523003: Add PaintController::showDebugDataWithPictures() (Closed)
Patch Set: ndef NDEBUG Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
index d4fbb3dac56e7868839c0e098344c6d6f5a011c0..73c11d22019c9eddfc4102a86a68f05fb34b4d54 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
@@ -150,7 +150,10 @@ public:
void appendDebugDrawingAfterCommit(const DisplayItemClient&, sk_sp<SkPicture>, const LayoutSize& offsetFromLayoutObject);
- void showDebugData() const;
+ void showDebugData() const { showDebugDataInternal(false); }
+#ifndef NDEBUG
+ void showDebugDataWithPictures() const { showDebugDataInternal(true); }
+#endif
#if DCHECK_IS_ON()
void assertDisplayItemClientsAreLive();
@@ -191,7 +194,8 @@ private:
enum NewItemSource { FromCachedItem, FromCachedSubsequence, NewPainting };
void processNewItem(DisplayItem&, NewItemSource);
- String displayItemListAsDebugString(const DisplayItemList&) const;
+ void showDebugDataInternal(bool showPictures) const;
+ String displayItemListAsDebugString(const DisplayItemList&, bool showPictures) const;
// Maps clients to indices of display items or chunks of each client.
using IndicesByClientMap = HashMap<const DisplayItemClient*, Vector<size_t>>;
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698