Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2324523003: Add PaintController::showDebugDataWithPictures() (Closed)

Created:
4 years, 3 months ago by Xianzhu
Modified:
4 years, 3 months ago
Reviewers:
chrishtr
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PaintController::showDebugDataWithPictures() CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/9b03b3e0806a0fb2aa8e8c0ee4d35293906e0e9d Cr-Commit-Position: refs/heads/master@{#417459}

Patch Set 1 #

Patch Set 2 : ndef NDEBUG #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Xianzhu
4 years, 3 months ago (2016-09-08 18:31:17 UTC) #4
chrishtr
lgtm
4 years, 3 months ago (2016-09-08 20:45:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324523003/20001
4 years, 3 months ago (2016-09-08 21:00:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324523003/20001
4 years, 3 months ago (2016-09-08 22:52:45 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 00:43:25 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 00:46:53 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b03b3e0806a0fb2aa8e8c0ee4d35293906e0e9d
Cr-Commit-Position: refs/heads/master@{#417459}

Powered by Google App Engine
This is Rietveld 408576698