Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2324503002: clang_linux: also build an MSAN libc++ (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org, jcgregorio
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

clang_linux: also build an MSAN libc++ This will be used by MSAN bots: build with -stdlib=libc++, then run with LD_LIBRARY_PATH=/path/to/clang_linux/msan. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324503002 Committed: https://skia.googlesource.com/skia/+/1a9466799ecde49f6231c9b79f4745fb789836c2

Patch Set 1 #

Patch Set 2 : simplify #

Patch Set 3 : version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M infra/bots/assets/clang_linux/VERSION View 1 2 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/assets/clang_linux/create.py View 1 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mtklein_C
4 years, 3 months ago (2016-09-07 19:04:43 UTC) #7
borenet
LGTM
4 years, 3 months ago (2016-09-07 19:09:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324503002/40001
4 years, 3 months ago (2016-09-07 19:13:28 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 19:26:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1a9466799ecde49f6231c9b79f4745fb789836c2

Powered by Google App Engine
This is Rietveld 408576698