Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 23245012: Fix Views Combobox and Tree View text input. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address nit. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/combobox/combobox.cc
diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc
index 4c107886234848a180f2f8f35f684d9d6307249c..51b817cb3a2dc70196e1797f399fa4be76a5dc80 100644
--- a/ui/views/controls/combobox/combobox.cc
+++ b/ui/views/controls/combobox/combobox.cc
@@ -140,17 +140,14 @@ bool Combobox::OnKeyReleased(const ui::KeyEvent& e) {
}
void Combobox::OnFocus() {
+ View::OnFocus();
// Forward the focus to the wrapper.
- if (native_wrapper_) {
+ if (native_wrapper_)
native_wrapper_->SetFocus();
- NotifyAccessibilityEvent(ui::AccessibilityTypes::EVENT_FOCUS, true);
- } else {
- View::OnFocus(); // Will focus the RootView window (so we still get
- // keyboard messages).
- }
}
void Combobox::OnBlur() {
+ View::OnBlur();
if (selector_)
selector_->OnViewBlur();
if (native_wrapper_)

Powered by Google App Engine
This is Rietveld 408576698