Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: ui/views/controls/tree/tree_view.cc

Issue 23245012: Fix Views Combobox and Tree View text input. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Handle potential NULL from GetInputMethod(). Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/combobox/combobox.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/tree/tree_view.cc
diff --git a/ui/views/controls/tree/tree_view.cc b/ui/views/controls/tree/tree_view.cc
index 1d550a2ff75b849947c3e67e19514f9befc3c497..6b760755cacc0498c9627037fb887856e6a9c180 100644
--- a/ui/views/controls/tree/tree_view.cc
+++ b/ui/views/controls/tree/tree_view.cc
@@ -600,16 +600,16 @@ void TreeView::OnPaint(gfx::Canvas* canvas) {
void TreeView::OnFocus() {
View::OnFocus();
SchedulePaintForNode(selected_node_);
-
- // Notify the InputMethod so that it knows to query the TextInputClient.
if (GetInputMethod())
- GetInputMethod()->OnCaretBoundsChanged(this);
+ GetInputMethod()->OnFocus();
sky 2013/08/21 21:57:11 Having to put this in each override is error prone
msw 2013/08/21 22:57:19 Done.
}
void TreeView::OnBlur() {
SchedulePaintForNode(selected_node_);
if (selector_)
selector_->OnViewBlur();
+ if (GetInputMethod())
+ GetInputMethod()->OnBlur();
}
bool TreeView::OnClickOrTap(const ui::LocatedEvent& event) {
« no previous file with comments | « ui/views/controls/combobox/combobox.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698