[Offline Pages] Adds event logs for requests dropped due to number of start or complete attempts.

components/offline_pages/background/request_picker.cc

Index: components/offline_pages/background/request_picker.cc
diff --git a/components/offline_pages/background/request_picker.cc b/components/offline_pages/background/request_picker.cc
index c51f030d6f72829407dd0dfa96b0f1c1c08b3d3d..a31f6ee241a31cc106457573271a1013af2465d9 100644
--- a/components/offline_pages/background/request_picker.cc
+++ b/components/offline_pages/background/request_picker.cc
@@ -14,7 +14,7 @@ int signum(T t) {
   return (T(0) < t) - (t < T(0));
 }
 
-#define CALL_MEMBER_FUNCTION(object,ptrToMember)  ((object)->*(ptrToMember))
+#define CALL_MEMBER_FUNCTION(object, ptrToMember) ((object)->*(ptrToMember))
 }  // namespace
 
 namespace offline_pages {
@@ -257,10 +257,12 @@ void RequestPicker::OnRequestExpired(
     const RequestQueue::UpdateMultipleRequestResults& results,
     const std::vector<std::unique_ptr<SavePageRequest>> requests) {
   std::vector<std::unique_ptr<SavePageRequest>>::const_iterator request;
-  for (request = requests.begin(); request != requests.end(); ++request)
+  for (request = requests.begin(); request != requests.end(); ++request) {
     notifier_->NotifyCompleted(
         *(request->get()),
         RequestCoordinator::BackgroundSavePageResult::EXPIRED);
+    // TODO(dougarnett): Plumb in event logger and RecordDroppedSavePageRequest

[Pete Williamson, 2016/09/09 17:16:19]

This seems to my untrained eyes like a small amount of code, any reason not to
do it now?  (it being larger than it seems to me might be a good reason, for
instance).

[dougarnett, 2016/09/09 23:58:21]

Really just have a design question here about should we just pass the event
logger into the constructor. Should I go ahead and do that?

[Pete Williamson, 2016/09/10 00:14:13]

Yes, please, if it isn't a lot of work.  If it is, we can make a bug and do it
later.

[dougarnett, 2016/09/12 18:31:38]

Done.

+  }
 }
 
 }  // namespace offline_pages