Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: components/offline_pages/background/request_picker.cc

Issue 2324493005: [Offline Pages] Adds event logs for requests dropped due to number of start or complete attempts. (Closed)
Patch Set: Addresses dimich feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_picker.cc
diff --git a/components/offline_pages/background/request_picker.cc b/components/offline_pages/background/request_picker.cc
index c51f030d6f72829407dd0dfa96b0f1c1c08b3d3d..a199a372212959e7ebfb210e439e7a2f06ad8f54 100644
--- a/components/offline_pages/background/request_picker.cc
+++ b/components/offline_pages/background/request_picker.cc
@@ -14,17 +14,19 @@ int signum(T t) {
return (T(0) < t) - (t < T(0));
}
-#define CALL_MEMBER_FUNCTION(object,ptrToMember) ((object)->*(ptrToMember))
+#define CALL_MEMBER_FUNCTION(object, ptrToMember) ((object)->*(ptrToMember))
} // namespace
namespace offline_pages {
RequestPicker::RequestPicker(RequestQueue* requestQueue,
OfflinerPolicy* policy,
- RequestNotifier* notifier)
+ RequestNotifier* notifier,
+ RequestCoordinatorEventLogger* event_logger)
: queue_(requestQueue),
policy_(policy),
notifier_(notifier),
+ event_logger_(event_logger),
fewer_retries_better_(false),
earlier_requests_better_(false),
weak_ptr_factory_(this) {}
@@ -257,10 +259,14 @@ void RequestPicker::OnRequestExpired(
const RequestQueue::UpdateMultipleRequestResults& results,
const std::vector<std::unique_ptr<SavePageRequest>> requests) {
std::vector<std::unique_ptr<SavePageRequest>>::const_iterator request;
- for (request = requests.begin(); request != requests.end(); ++request)
- notifier_->NotifyCompleted(
- *(request->get()),
+ for (request = requests.begin(); request != requests.end(); ++request) {
+ const RequestCoordinator::BackgroundSavePageResult result(
RequestCoordinator::BackgroundSavePageResult::EXPIRED);
+ event_logger_->RecordDroppedSavePageRequest(
+ request->get()->client_id().name_space, result,
+ request->get()->request_id());
+ notifier_->NotifyCompleted(*(request->get()), result);
+ }
}
} // namespace offline_pages
« no previous file with comments | « components/offline_pages/background/request_picker.h ('k') | components/offline_pages/background/request_picker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698