Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2324493002: Improve minification of frontend Polymer Elements (Closed)

Created:
4 years, 3 months ago by kjlubick
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Base URL:
git@github.com:luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Improve minification of frontend Polymer Elements Before: 791K (168K gzipped) After: 439K (117K gzipped) Diff: -44% (-30% gzipped) Rietveld is giving me a "patch too big" error, so I might have to land this manually BUG=631047 R=jcgregorio@google.com, kjlubick@chromium.org Committed: https://github.com/luci/luci-py/commit/4d7d87e66e141d106821c4c9decc1b693ada1afb

Patch Set 1 #

Patch Set 2 : trying to remove elements #

Patch Set 3 : remake #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M appengine/swarming/elements/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/build/js/js.js View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/package.json View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
kjlubick
4 years, 3 months ago (2016-09-07 18:44:16 UTC) #3
jcgregorio
lgtm
4 years, 3 months ago (2016-09-07 18:59:23 UTC) #5
jcgregorio
On 2016/09/07 at 18:59:23, jcgregorio wrote: > lgtm Need to roll this into buildbot/infra also!
4 years, 3 months ago (2016-09-07 18:59:49 UTC) #6
KevinL
lgtm
4 years, 3 months ago (2016-09-07 19:27:26 UTC) #8
kjlubick
4 years, 3 months ago (2016-09-07 19:33:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:30001) manually as
4d7d87e66e141d106821c4c9decc1b693ada1afb.

Powered by Google App Engine
This is Rietveld 408576698