Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2324483002: Enables media_mojo_unittests on linux bots. (Closed)

Created:
4 years, 3 months ago by alokp
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enables media_mojo_unittests on linux bots. BUG=571155 Committed: https://crrev.com/ac882d3ce7c0d99292439bf3405780058fcca0a6 Cr-Commit-Position: refs/heads/master@{#417412}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M testing/buildbot/chromium.linux.json View 3 chunks +18 lines, -0 lines 3 comments Download

Messages

Total messages: 16 (8 generated)
alokp
4 years, 3 months ago (2016-09-07 18:32:29 UTC) #4
DaleCurtis
lgtm
4 years, 3 months ago (2016-09-08 16:42:41 UTC) #7
alokp
+stip since dpranke is OOO.
4 years, 3 months ago (2016-09-08 16:58:41 UTC) #9
ghost stip (do not use)
lgtm https://codereview.chromium.org/2324483002/diff/1/testing/buildbot/chromium.linux.json File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/2324483002/diff/1/testing/buildbot/chromium.linux.json#newcode1601 testing/buildbot/chromium.linux.json:1601: "test": "media_mojo_unittests" reviewer note: Cast Linux https://codereview.chromium.org/2324483002/diff/1/testing/buildbot/chromium.linux.json#newcode1936 testing/buildbot/chromium.linux.json:1936: ...
4 years, 3 months ago (2016-09-08 19:34:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324483002/1
4 years, 3 months ago (2016-09-08 20:08:54 UTC) #12
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-08 21:32:39 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 21:58:59 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 22:01:57 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac882d3ce7c0d99292439bf3405780058fcca0a6
Cr-Commit-Position: refs/heads/master@{#417412}

Powered by Google App Engine
This is Rietveld 408576698