Remove old dartium_factory builders, clean up slaves.cfg files.

Remove old dartium_factory builders, clean up slaves.cfg files.

Also removes dartium_factory code and fixes a bug in dartium recipe.

BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=618379

Committed: https://chromium.googlesource.com/chromium/tools/build/+/fedd382eb821d2766ff835440d6017b357b7edff

[Bill Hesse, 2016-09-08 16:27:00]

whesse@google.com changed reviewers:
+ kustermann@google.com

[Bill Hesse, 2016-09-08 16:27:01]

https://codereview.chromium.org/2324463003/diff/1/masters/master.client.dart....
File masters/master.client.dart.fyi/slaves.cfg (left):

https://codereview.chromium.org/2324463003/diff/1/masters/master.client.dart....
masters/master.client.dart.fyi/slaves.cfg:113: 'hostname': 'vm608-m3',
These slaves are all returning to c-i-t.

[kustermann, 2016-09-08 16:44:44]

lgtm

https://codereview.chromium.org/2324463003/diff/1/masters/master.client.dart....
File masters/master.client.dart.fyi/master.cfg (right):

https://codereview.chromium.org/2324463003/diff/1/masters/master.client.dart....
masters/master.client.dart.fyi/master.cfg:261: # normal builders + editor
builders
We don't have "editor_builders" anymore

https://codereview.chromium.org/2324463003/diff/1/masters/master.client.dart....
File masters/master.client.dart.fyi/slaves.cfg (right):

https://codereview.chromium.org/2324463003/diff/1/masters/master.client.dart....
masters/master.client.dart.fyi/slaves.cfg:156: return channel != '-integration'
Do we still have the integration branch / builders for it. If not I'd get rid of
"integration" related things in master.cfg and slaves.cfg as well.

[Bill Hesse, 2016-09-08 17:25:24]

https://codereview.chromium.org/2324463003/diff/1/masters/master.client.dart....
File masters/master.client.dart.fyi/master.cfg (right):

https://codereview.chromium.org/2324463003/diff/1/masters/master.client.dart....
masters/master.client.dart.fyi/master.cfg:261: # normal builders + editor
builders
On 2016/09/08 16:44:44, kustermann wrote:
> We don't have "editor_builders" anymore

Done.

https://codereview.chromium.org/2324463003/diff/1/masters/master.client.dart....
File masters/master.client.dart.fyi/slaves.cfg (right):

https://codereview.chromium.org/2324463003/diff/1/masters/master.client.dart....
masters/master.client.dart.fyi/slaves.cfg:156: return channel != '-integration'
On 2016/09/08 16:44:44, kustermann wrote:
> Do we still have the integration branch / builders for it. If not I'd get rid
of
> "integration" related things in master.cfg and slaves.cfg as well.

We still have it on the main waterfall, and CHANNELS, which we iterate over,
contains it.  Right now, there is nothing on it on the fyi master, this one,
which this line emphasises.

[William Hesse, 2016-09-08 17:41:09]

whesse@chromium.org changed reviewers:
+ whesse@chromium.org

[William Hesse, 2016-09-08 17:41:09]

lgtm

[Bill Hesse, 2016-09-09 07:51:59]

The CQ bit was checked by whesse@google.com

[Bill Hesse, 2016-09-09 07:52:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
kustermann@google.com
Link to the patchset: https://codereview.chromium.org/2324463003/#ps30001
(title: "Fix typo")

[commit-bot: I haz the power, 2016-09-09 07:52:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 07:56:25]

Description was changed from

==========
Remove old dartium_factory builders, clean up slaves.cfg files.

Also removes dartium_factory code and fixes a bug in dartium recipe.

BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=618379
==========

to

==========
Remove old dartium_factory builders, clean up slaves.cfg files.

Also removes dartium_factory code and fixes a bug in dartium recipe.

BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=618379

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/fedd382eb821d2766ff8...
==========

[commit-bot: I haz the power, 2016-09-09 07:56:26]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/tools/build/+/fedd382eb821d2766ff8...