Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 232443002: Revert of Blink roll 171141:171171 (Closed)

Created:
6 years, 8 months ago by tapted
Modified:
6 years, 8 months ago
Reviewers:
yurys, jianli
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Blink roll 171141:171171 (https://codereview.chromium.org/231713002/) Reason for revert: Compile errors on chromiumos builder [multiple cycles] due to https://src.chromium.org/viewvc/blink?revision=171165&view=revision /third_party/WebKit/Source/core/dom/CharacterData.cpp:146:36: error: 'realCount' may be used uninitialized in this function [-Werror=maybe-uninitialized] chromeos-chrome-36.0.1933.0_alpha-r1: newStr.remove(offset, realCount); link: http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/20955 Original issue's description: > Blink roll 171141:171171 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171141:171171&mode=html > TBR= > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262863 TBR=yurys@chromium.org,jianli@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of Blink roll 171141:171171
6 years, 8 months ago (2014-04-10 03:19:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/232443002/1
6 years, 8 months ago (2014-04-10 03:19:51 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 03:20:23 UTC) #3
Message was sent while issue was closed.
Change committed as 262905

Powered by Google App Engine
This is Rietveld 408576698