Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 23244002: gpu: Add Serialize function to ContextCreationAttribParser. (Closed)

Created:
7 years, 4 months ago by reveman
Modified:
7 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

gpu: Add Serialize function to ContextCreationAttribParser. Rename ContextCreationAttribParser to ContextCreationAttribHelper and add Serialize function. TEST=gl_tests BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217898

Patch Set 1 #

Patch Set 2 : fix serialize of swap behavior and rename constants #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -54 lines) Patch
M gpu/command_buffer/common/gles2_cmd_utils.h View 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 3 chunks +79 lines, -32 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 3 chunks +8 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
reveman
7 years, 4 months ago (2013-08-15 15:01:57 UTC) #1
piman
LGTM. Maybe we could also rename those constants for command buffers purpose (while keeping the ...
7 years, 4 months ago (2013-08-15 17:13:36 UTC) #2
reveman
On 2013/08/15 17:13:36, piman wrote: > LGTM. Maybe we could also rename those constants for ...
7 years, 4 months ago (2013-08-15 17:36:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/23244002/1
7 years, 4 months ago (2013-08-15 17:36:24 UTC) #4
reveman
included the rename of constants in this patch after finding an issue with how swap ...
7 years, 4 months ago (2013-08-15 18:04:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/23244002/19001
7 years, 4 months ago (2013-08-15 18:05:15 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=160403
7 years, 4 months ago (2013-08-15 19:09:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/23244002/19001
7 years, 4 months ago (2013-08-15 19:15:32 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=160440
7 years, 4 months ago (2013-08-15 20:04:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/23244002/19001
7 years, 4 months ago (2013-08-15 20:53:35 UTC) #10
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 00:59:02 UTC) #11
Message was sent while issue was closed.
Change committed as 217898

Powered by Google App Engine
This is Rietveld 408576698