Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2324313002: DevTools: Add buttons to add box-shadow and text-shadow properties in SSP (Closed)

Created:
4 years, 3 months ago by flandy
Modified:
4 years, 3 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add buttons to add box-shadow and text-shadow properties in SSP These buttons will appear in same toolbar as "Add background-color" and "Add color." BUG=639095 Committed: https://crrev.com/390740329c93bc376ee8aa7395af8ef3591d8322 Cr-Commit-Position: refs/heads/master@{#418759}

Patch Set 1 #

Patch Set 2 : Resolve black box #

Total comments: 4

Patch Set 3 : Merge similar functions #

Patch Set 4 : Rename function #

Messages

Total messages: 14 (5 generated)
flandy
Please take a look! See the bug for a screenshot.
4 years, 3 months ago (2016-09-09 23:30:21 UTC) #2
lushnikov
https://codereview.chromium.org/2324313002/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/2324313002/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode715 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:715: textShadowButton.addEventListener("click", this._onInsertTextShadowPropertyClick.bind(this)); this._onShadowButtonClick.bind(this, "text-shadow") https://codereview.chromium.org/2324313002/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode896 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:896: _onInsertTextShadowPropertyClick: function(event) onShadowButtonClick: ...
4 years, 3 months ago (2016-09-10 00:17:23 UTC) #3
flandy
https://codereview.chromium.org/2324313002/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/2324313002/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode715 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:715: textShadowButton.addEventListener("click", this._onInsertTextShadowPropertyClick.bind(this)); On 2016/09/10 00:17:23, lushnikov wrote: > this._onShadowButtonClick.bind(this, ...
4 years, 3 months ago (2016-09-10 00:26:04 UTC) #4
lushnikov
lgtm
4 years, 3 months ago (2016-09-10 00:35:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324313002/60001
4 years, 3 months ago (2016-09-10 00:35:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/290972)
4 years, 3 months ago (2016-09-10 02:20:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324313002/60001
4 years, 3 months ago (2016-09-15 00:55:15 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-15 02:16:16 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 02:18:21 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/390740329c93bc376ee8aa7395af8ef3591d8322
Cr-Commit-Position: refs/heads/master@{#418759}

Powered by Google App Engine
This is Rietveld 408576698