LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-inheritance.html - Issue 23243002: Introduce XMLHttpRequestEventTarget IDL interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-inheritance.html

Issue 23243002: Introduce XMLHttpRequestEventTarget IDL interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix nits and add test Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <link rel="help" href="http://www.w3.org/TR/2012/WD-XMLHttpRequest-20121206/#xml httprequesteventtarget">

	5 <script src="../resources/js-test-pre.js"></script>

	6 </head>

	7 <body>

	8 <script>

	9 description("Checks the prototype chain of XMLHttpRequest / XMLHttpRequestUpload .");

	10

	11 // XMLHttpRequest.

	12 shouldBeEqualToString("XMLHttpRequest.__proto__.name", "XMLHttpRequestEventTarge t");

	13 shouldBeEqualToString("XMLHttpRequest.prototype.__proto__.constructor.name", "XM LHttpRequestEventTarget");

	14 shouldBe("XMLHttpRequest.prototype.__proto__.__proto__", "EventTarget.prototype" );

	15

	16 // XMLHttpRequestUpload.

	17 shouldBeEqualToString("XMLHttpRequestUpload.__proto__.name", "XMLHttpRequestEven tTarget");

	18 shouldBeEqualToString("XMLHttpRequestUpload.prototype.__proto__.constructor.name ", "XMLHttpRequestEventTarget");

	19 shouldBe("XMLHttpRequestUpload.prototype.__proto__.__proto__", "EventTarget.prot otype");
	arv (Not doing code reviews) 2013/08/15 15:02:50 Also: function className(obj) { return Object.p Also: function className(obj) { return Object.prototype.toString.call(obj).slice(8, -1); } shouldBeEqualToString("className(XMLHttpRequest.prototype.__proto__", "XMLHttpRequestEventTargetPrototype"); This will be a FAIL because we incorrectly set the [[Class]] to "XMLHttpRequestEventTarget" do-not-use 2013/08/15 15:33:45 I added the check. toString() actually returns Obj Show quoted text On 2013/08/15 15:02:50, arv wrote: > Also: > > function className(obj) { > return Object.prototype.toString.call(obj).slice(8, -1); > } > > shouldBeEqualToString("className(XMLHttpRequest.prototype.__proto__", > "XMLHttpRequestEventTargetPrototype"); > > This will be a FAIL because we incorrectly set the [[Class]] to > "XMLHttpRequestEventTarget" I added the check. toString() actually returns Object. iirc this is not easily fixable because there is no API in v8 to set the class name of the prototype template, right? (I mean no ObjectTemplate::SetClassName()).
	20 </script>

	21 </body>

	22 <script src="../resources/js-test-post.js"></script>

	23 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-inheritance-expected.txt » ('j') | no next file with comments »