Use 'draft' status to restrict access to private Gerrit reviews

Use 'draft' status to restrict access to private Gerrit reviews

R=andybons@chromium.org, tandrii@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/c6787971b576148c94d8dc11dc3d28e88c971995

[Bons, 2016-09-09 21:45:38]

lgtm

I’m assuming that the gerrit config restricts access to draft comments?
Otherwise this is sort of a no-op. :)

[agable, 2016-09-09 21:56:34]

On 2016/09/09 at 21:45:38, andybons wrote:
> lgtm
> 
> I’m assuming that the gerrit config restricts access to draft comments?
Otherwise this is sort of a no-op. :)

I know nothing about drafts, I'm just going off of what you and dborowitz said
in that email thread :)

I'll upload a draft change and see what it looks like and fiddle with it until
it works.

[Bons, 2016-09-09 21:58:02]

On 2016/09/09 21:56:34, agable wrote:
> On 2016/09/09 at 21:45:38, andybons wrote:
> > lgtm
> > 
> > I’m assuming that the gerrit config restricts access to draft comments?
> Otherwise this is sort of a no-op. :)
> 
> I know nothing about drafts, I'm just going off of what you and dborowitz said
> in that email thread :)
> 
> I'll upload a draft change and see what it looks like and fiddle with it until
> it works.

👍

[agable, 2016-09-09 23:07:36]

Tested, fixed a bug, now totes works.

[agable, 2016-09-09 23:07:37]

The CQ bit was checked by agable@chromium.org

[agable, 2016-09-09 23:07:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/2324283002/#ps20001
(title: "Fix extend vs. append")

[commit-bot: I haz the power, 2016-09-09 23:07:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 23:13:36]

Description was changed from

==========
Use 'draft' status to restrict access to private Gerrit reviews

R=andybons@chromium.org, tandrii@chromium.org
==========

to

==========
Use 'draft' status to restrict access to private Gerrit reviews

R=andybons@chromium.org, tandrii@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/c6787971b57614...
==========

[commit-bot: I haz the power, 2016-09-09 23:13:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/c6787971b57614...