Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2575)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2324263002: Follow up "Trigger app banner when add to homescreen is pressed and WebAPKs are enabled." (Closed)
Patch Set: Nits. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/banners/app_banner_infobar_delegate_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index ab2aabaaa4476bbdcc423f30e85a00231e450667..5f9c317da1981491bd877ec5240e08bbd84a468a 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -34,10 +34,6 @@ DEFINE_WEB_CONTENTS_USER_DATA_KEY(banners::AppBannerManagerAndroid);
namespace {
-const char kReferrerName[] = "referrer";
-const char kIdName[] = "id";
-const char kPlayInlineReferrer[] = "playinline=chrome_inline";
-
std::unique_ptr<ShortcutInfo> CreateShortcutInfo(
const GURL& manifest_url,
const content::Manifest& manifest,
@@ -236,20 +232,18 @@ bool AppBannerManagerAndroid::CanHandleNonWebApp(const std::string& platform,
if (java_banner_manager_.is_null())
return false;
- std::string id_from_app_url = ExtractQueryValueForName(url, kIdName);
+ std::string id_from_app_url = ExtractQueryValueForName(url, "id");
if (id_from_app_url.size() && id != id_from_app_url) {
ReportStatus(web_contents(), IDS_DO_NOT_MATCH);
return false;
}
- std::string referrer = ExtractQueryValueForName(url, kReferrerName);
-
// Attach the chrome_inline referrer value, prefixed with "&" if the referrer
// is non empty.
- if (referrer.empty())
- referrer = kPlayInlineReferrer;
- else
- referrer.append("&").append(kPlayInlineReferrer);
+ std::string referrer = ExtractQueryValueForName(url, "referrer");
+ if (!referrer.empty())
+ referrer += "&";
+ referrer += "playinline=chrome_inline";
ScopedJavaLocalRef<jstring> jurl(
ConvertUTF8ToJavaString(env, validated_url_.spec()));
« no previous file with comments | « chrome/browser/android/banners/app_banner_infobar_delegate_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698