build kernel for the entire program after resolution

build kernel for the entire program after resolution

Rasta needs to have access to elements that aren't resolved by normal
dart2js. We need to let it add elements to the resolution queue so
it can get all the information it needs.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/53870d1914ff67a08cac906d79de118279966065

[Harry Terkelsen, 2016-09-09 22:35:40]

het@google.com changed reviewers:
+ sigmund@google.com

[Harry Terkelsen, 2016-09-09 22:36:16]

Description was changed from

==========
build kernel for the entire program after resolution

Rasta needs to have access to elements that aren't resolved by normal
dart2js. We need to let it add elements to the resolution queue so
it can get all the information it needs.
==========

to

==========
build kernel for the entire program after resolution

Rasta needs to have access to elements that aren't resolved by normal
dart2js. We need to let it add elements to the resolution queue so
it can get all the information it needs.
==========

[Siggi Cherem (dart-lang), 2016-09-09 22:49:24]

lgtm, nice!

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:2373: kernelTask.onQueueEmpty();
nit: rename "onQueueEmpty" to "buildKernelIr"?

I started doing a rename where methods have a "onFoo" name only if they are a
callback of another part of the compiler that is supposed to be agnostic about
what the callback does (e.g. the queue should not know what the backend does
onQueueEmpty). Everywhere else (like here) I'd like to rename methods to have a
name that just describes what they do. WDYT?

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/kernel.dart (left):

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/kernel.dart:361: moveSuperCallLast(constructor);
any reason this is removed?

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:40: //      Kernel kernel = new
Kernel(backend.compiler);
delete?

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_impact.dart (right):

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_impact.dart:25: //  Kernel kernel = new
Kernel(compiler);
ditto?

[Harry Terkelsen, 2016-09-09 22:56:47]

Thanks, Siggi!

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:2373: kernelTask.onQueueEmpty();
On 2016/09/09 22:49:23, Siggi Cherem (dart-lang) wrote:
> nit: rename "onQueueEmpty" to "buildKernelIr"?
> 
> I started doing a rename where methods have a "onFoo" name only if they are a
> callback of another part of the compiler that is supposed to be agnostic about
> what the callback does (e.g. the queue should not know what the backend does
> onQueueEmpty). Everywhere else (like here) I'd like to rename methods to have
a
> name that just describes what they do. WDYT?

Done. I think that's better, I was mainly naming it this to be consistent

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/kernel.dart (left):

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/kernel.dart:361: moveSuperCallLast(constructor);
On 2016/09/09 22:49:23, Siggi Cherem (dart-lang) wrote:
> any reason this is removed?

Not 100% sure. As part of this CL I also merged this file with the latest rasta,
which also got rid of it. Maybe newest kernel automatically does that
transformation? I should update our kernel dependency actually... will do in a
follow-up CL

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:40: //      Kernel kernel = new
Kernel(backend.compiler);
On 2016/09/09 22:49:23, Siggi Cherem (dart-lang) wrote:
> delete?

Done.

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_impact.dart (right):

https://codereview.chromium.org/2324213003/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_impact.dart:25: //  Kernel kernel = new
Kernel(compiler);
On 2016/09/09 22:49:23, Siggi Cherem (dart-lang) wrote:
> ditto?

Done.

[Harry Terkelsen, 2016-09-09 23:06:26]

Description was changed from

==========
build kernel for the entire program after resolution

Rasta needs to have access to elements that aren't resolved by normal
dart2js. We need to let it add elements to the resolution queue so
it can get all the information it needs.
==========

to

==========
build kernel for the entire program after resolution

Rasta needs to have access to elements that aren't resolved by normal
dart2js. We need to let it add elements to the resolution queue so
it can get all the information it needs.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/53870d1914ff67a08cac906d79de118279966065
==========

[Harry Terkelsen, 2016-09-09 23:06:27]

Committed patchset #2 (id:20001) manually as
53870d1914ff67a08cac906d79de118279966065 (presubmit successful).