Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: net/quic/chromium/quic_http_stream.cc

Issue 2324183002: Implement QuicHttpStream::GetLoadTimingInfo (Closed)
Patch Set: fix flaky TestTwoRequests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_http_stream.h ('k') | net/quic/chromium/quic_http_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_http_stream.cc
diff --git a/net/quic/chromium/quic_http_stream.cc b/net/quic/chromium/quic_http_stream.cc
index 5aba9263cf2661058a84d647c2c60df206639ddd..16447899be3ce42ac65ddede9bcb790ee07c306e 100644
--- a/net/quic/chromium/quic_http_stream.cc
+++ b/net/quic/chromium/quic_http_stream.cc
@@ -58,6 +58,7 @@ QuicHttpStream::QuicHttpStream(
headers_bytes_sent_(0),
closed_stream_received_bytes_(0),
closed_stream_sent_bytes_(0),
+ closed_is_first_stream_(false),
user_buffer_len_(0),
quic_connection_error_(QUIC_NO_ERROR),
port_migration_detected_(false),
@@ -398,7 +399,15 @@ int64_t QuicHttpStream::GetTotalSentBytes() const {
}
bool QuicHttpStream::GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const {
- // TODO(mmenke): Figure out what to do here.
+ bool is_first_stream = closed_is_first_stream_;
+ if (stream_)
+ is_first_stream = stream_->IsFirstStream();
+ if (is_first_stream) {
+ load_timing_info->socket_reused = false;
+ load_timing_info->connect_timing = connect_timing_;
+ } else {
+ load_timing_info->socket_reused = true;
+ }
return true;
}
@@ -800,6 +809,9 @@ int QuicHttpStream::ProcessResponseHeaders(const SpdyHeaderBlock& headers) {
response_info_->request_time = request_time_;
response_headers_received_ = true;
+ // Populate |connect_timing_| when response headers are received. This should
+ // take care of 0-RTT where request is sent before handshake is confirmed.
+ connect_timing_ = session_->GetConnectTiming();
return OK;
}
@@ -829,6 +841,7 @@ void QuicHttpStream::ResetStream() {
return;
closed_stream_received_bytes_ = stream_->stream_bytes_read();
closed_stream_sent_bytes_ = stream_->stream_bytes_written();
+ closed_is_first_stream_ = stream_->IsFirstStream();
stream_ = nullptr;
// If |request_body_stream_| is non-NULL, Reset it, to abort any in progress
« no previous file with comments | « net/quic/chromium/quic_http_stream.h ('k') | net/quic/chromium/quic_http_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698