Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2324173002: Revert of [gn] Switch off gyp in runhooks by default (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [gn] Switch off gyp in runhooks by default (patchset #2 id:20001 of https://codereview.chromium.org/2327033002/ ) Reason for revert: Broke stuff - need to fix the argument Original issue's description: > [gn] Switch off gyp in runhooks by default > > This will be synced with an announcement on v8-dev. This > doesn't affect directly calling gyp in our old Makefiles. > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/94f813e8dcd4ed5a67cede8af0f949009beaa501 > Cr-Commit-Position: refs/heads/master@{#39308} TBR=jochen@chromium.org,jkummerow@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Committed: https://crrev.com/2931e42d46c89f76892bf3ba78a3aace23d706a5 Cr-Commit-Position: refs/heads/master@{#39309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gypfiles/gyp_v8 View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [gn] Switch off gyp in runhooks by default
4 years, 3 months ago (2016-09-09 14:09:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324173002/1
4 years, 3 months ago (2016-09-09 14:09:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 14:09:33 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 14:10:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2931e42d46c89f76892bf3ba78a3aace23d706a5
Cr-Commit-Position: refs/heads/master@{#39309}

Powered by Google App Engine
This is Rietveld 408576698