Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: services/ui/display/platform_screen_ozone.h

Issue 2324163002: Add FakeDisplayDelegate for off device usage. (Closed)
Patch Set: Address rjkroege comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/display/platform_screen_ozone.h
diff --git a/services/ui/display/platform_screen_ozone.h b/services/ui/display/platform_screen_ozone.h
index 521ead33aa394f005efe4fc06a817f032b788894..58aefe7bcceeaf48f8d85a0e8af6f6b90d953899 100644
--- a/services/ui/display/platform_screen_ozone.h
+++ b/services/ui/display/platform_screen_ozone.h
@@ -19,6 +19,7 @@
#include "services/ui/public/interfaces/display/display_controller.mojom.h"
#include "ui/display/chromeos/display_configurator.h"
#include "ui/display/display.h"
+#include "ui/display/types/fake_display_controller.h"
namespace display {
@@ -102,6 +103,14 @@ class PlatformScreenOzone
ui::DisplayConfigurator display_configurator_;
PlatformScreenDelegate* delegate_ = nullptr;
+ // If not null it provides a way to modify the display state when running off
msw 2016/09/15 19:30:08 optional nit: "when running without a device (ie.
kylechar 2016/09/15 21:35:40 It's the terminology Rob and I have been using, no
+ // device.
+ FakeDisplayController* fake_display_controller_ = nullptr;
+
+ // Tracks if we've made some type of change and want to wait for the display
+ // configuration to update before making further changes.
+ bool wait_for_display_update_ = false;
msw 2016/09/15 19:30:08 optional nit: specialize this flag and comment for
kylechar 2016/09/15 21:35:40 I'm not totally sure there is a case where we want
+
// TODO(kylechar): These values can/should be replaced by DisplayLayout.
int64_t primary_display_id_ = display::Display::kInvalidDisplayID;
std::vector<DisplayInfo> cached_displays_;
« no previous file with comments | « no previous file | services/ui/display/platform_screen_ozone.cc » ('j') | services/ui/display/platform_screen_ozone.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698