Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4310)

Unified Diff: chrome/browser/media/router/mojo/media_router.mojom

Issue 2324133003: [Media Router] Use TimeDelta in mojo interfaces (Closed)
Patch Set: Fix mojo test compile Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/router/BUILD.gn ('k') | chrome/browser/media/router/mojo/media_router_mojo_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/router/mojo/media_router.mojom
diff --git a/chrome/browser/media/router/mojo/media_router.mojom b/chrome/browser/media/router/mojo/media_router.mojom
index 9ae7d5105c2afa15532a5d8b2f8dd13ee05dd715..0971cb5b24fc5a12605477ef7b5f6c65a8d2b6d2 100644
--- a/chrome/browser/media/router/mojo/media_router.mojom
+++ b/chrome/browser/media/router/mojo/media_router.mojom
@@ -4,6 +4,8 @@
module media_router.mojom;
+import "mojo/common/common_custom_types.mojom";
+
// Represents an output sink to which media can be routed.
struct MediaSink {
enum IconType {
@@ -150,8 +152,8 @@ interface MediaRouteProvider {
// same-tab scopes. Use -1 as |tab_id| in cases where the request is not
// made on behalf of a tab.
//
- // If |timeout_millis| is positive, it will be used in place of the default
- // timeout defined by Media Route Provider Manager.
+ // If |timeout| is positive, it will be used in place of the default timeout
+ // defined by Media Route Provider Manager.
//
// If |incognito| is true, the request was made by an incognito profile.
//
@@ -166,7 +168,7 @@ interface MediaRouteProvider {
string original_presentation_id,
string origin,
int32 tab_id,
- int64 timeout_millis,
+ mojo.common.mojom.TimeDelta timeout,
bool incognito) =>
(MediaRoute? route,
string? error_text,
@@ -178,8 +180,8 @@ interface MediaRouteProvider {
// |origin| and |tab_id| are used for validating same-origin/tab scopes;
// see CreateRoute for additional documentation.
//
- // If |timeout_millis| is positive, it will be used in place of the default
- // timeout defined by Media Route Provider Manager.
+ // If |timeout| is positive, it will be used in place of the default timeout
+ // defined by Media Route Provider Manager.
//
// If the route request was created by an incognito profile,
// |incognito| must be true.
@@ -194,7 +196,7 @@ interface MediaRouteProvider {
string presentation_id,
string origin,
int32 tab_id,
- int64 timeout_millis,
+ mojo.common.mojom.TimeDelta timeout,
bool incognito) =>
(MediaRoute? route,
string? error_text,
@@ -210,9 +212,9 @@ interface MediaRouteProvider {
// |origin| and |tab_id| are used for validating same-origin/tab scopes; see
// CreateRoute for additional documentation.
//
- // If |timeout_millis| is positive, it will be used in place of the default
- // timeout defined by Media Route Provider Manager; see CreateRoute for
- // additional documentation.
+ // If |timeout| is positive, it will be used in place of the default timeout
+ // defined by Media Route Provider Manager; see CreateRoute for additional
+ // documentation.
//
// If the route request was created by an incognito profile,
// |incognito| must be true.
@@ -228,7 +230,7 @@ interface MediaRouteProvider {
string presentation_id,
string origin,
int32 tab_id,
- int64 timeout_millis,
+ mojo.common.mojom.TimeDelta timeout,
bool incognito) =>
(MediaRoute? route,
string? error_text,
« no previous file with comments | « chrome/browser/media/router/BUILD.gn ('k') | chrome/browser/media/router/mojo/media_router_mojo_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698