[Media Router] Use TimeDelta in mojo interfaces

chrome/browser/media/router/mojo/media_router.mojom

Index: chrome/browser/media/router/mojo/media_router.mojom
diff --git a/chrome/browser/media/router/mojo/media_router.mojom b/chrome/browser/media/router/mojo/media_router.mojom
index 9ae7d5105c2afa15532a5d8b2f8dd13ee05dd715..0971cb5b24fc5a12605477ef7b5f6c65a8d2b6d2 100644
--- a/chrome/browser/media/router/mojo/media_router.mojom
+++ b/chrome/browser/media/router/mojo/media_router.mojom
@@ -4,6 +4,8 @@
 
 module media_router.mojom;
 
+import "mojo/common/common_custom_types.mojom";
+
 // Represents an output sink to which media can be routed.
 struct MediaSink {
   enum IconType {
@@ -150,8 +152,8 @@ interface MediaRouteProvider {
   // same-tab scopes. Use -1 as |tab_id| in cases where the request is not
   // made on behalf of a tab.
   //
-  // If |timeout_millis| is positive, it will be used in place of the default
-  // timeout defined by Media Route Provider Manager.
+  // If |timeout| is positive, it will be used in place of the default timeout
+  // defined by Media Route Provider Manager.
   //
   // If |incognito| is true, the request was made by an incognito profile.
   //
@@ -166,7 +168,7 @@ interface MediaRouteProvider {
               string original_presentation_id,
               string origin,
               int32 tab_id,
-              int64 timeout_millis,
+              mojo.common.mojom.TimeDelta timeout,

[miu, 2016/09/10 00:40:17]

OOC, why not use base::TimeDelta instead (here and throughout)? IMHO, would be
much more readable.

[btolsch, 2016/09/10 00:51:39]

I'm not sure I understand the question but I'll try to give some reasoning. 
Even when using typemaps, the mojo interface needs to use mojo types;
base::TimeDelta is only known to c++.  TimeDelta was formerly declared a
[Native] struct so that there was no additional implementation needed for mojo
to use it (uses existing ipc::ParamTraits and member definition), but this only
works while in c++.  Since the extension bindings (javascript) need this type,
it needs to be a proper mojo struct.

[miu, 2016/09/10 23:25:40]

Whoops! My mistake. Thought I was looking at the C++ header
(media_router_mojo_impl.h). Never mind. ;-)

               bool incognito) =>
                   (MediaRoute? route,
                    string? error_text,
@@ -178,8 +180,8 @@ interface MediaRouteProvider {
   // |origin| and |tab_id| are used for validating same-origin/tab scopes;
   // see CreateRoute for additional documentation.
   //
-  // If |timeout_millis| is positive, it will be used in place of the default
-  // timeout defined by Media Route Provider Manager.
+  // If |timeout| is positive, it will be used in place of the default timeout
+  // defined by Media Route Provider Manager.
   //
   // If the route request was created by an incognito profile,
   // |incognito| must be true.
@@ -194,7 +196,7 @@ interface MediaRouteProvider {
             string presentation_id,
             string origin,
             int32 tab_id,
-            int64 timeout_millis,
+            mojo.common.mojom.TimeDelta timeout,
             bool incognito) =>
                 (MediaRoute? route,
                  string? error_text,
@@ -210,9 +212,9 @@ interface MediaRouteProvider {
   // |origin| and |tab_id| are used for validating same-origin/tab scopes; see
   // CreateRoute for additional documentation.
   //
-  // If |timeout_millis| is positive, it will be used in place of the default
-  // timeout defined by Media Route Provider Manager; see CreateRoute for
-  // additional documentation.
+  // If |timeout| is positive, it will be used in place of the default timeout
+  // defined by Media Route Provider Manager; see CreateRoute for additional
+  // documentation.
   //
   // If the route request was created by an incognito profile,
   // |incognito| must be true.
@@ -228,7 +230,7 @@ interface MediaRouteProvider {
                         string presentation_id,
                         string origin,
                         int32 tab_id,
-                        int64 timeout_millis,
+                        mojo.common.mojom.TimeDelta timeout,
                         bool incognito) =>
                             (MediaRoute? route,
                              string? error_text,