Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: LayoutTests/animations/resources/animation-test-helpers.js

Issue 23241010: Support subpixel values for text-shadow and box-shadow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: found one more spot Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/sub-pixel/shadows.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/animations/resources/animation-test-helpers.js
diff --git a/LayoutTests/animations/resources/animation-test-helpers.js b/LayoutTests/animations/resources/animation-test-helpers.js
index 78238385f85adad7bc0512e81d30f75341d823e3..de5cfa2abf192f729252e8d2c7ff88ec6e191061 100644
--- a/LayoutTests/animations/resources/animation-test-helpers.js
+++ b/LayoutTests/animations/resources/animation-test-helpers.js
@@ -381,7 +381,7 @@ function checkExpectedTransitionValue(expected, index)
if (property == 'box-shadow' || property == 'text-shadow') {
var text = computedStyle[i].cssText;
// Shadow cssText looks like "rgb(0, 0, 255) 0px -3px 10px 0px"
mithro-old 2013/10/24 00:45:41 Comment needs to be updated with the change to the
cbiesinger 2013/10/26 01:26:06 I guess... will do.
- var shadowPositionRegExp = /\)\s*(-?\d+)px\s*(-?\d+)px/;
+ var shadowPositionRegExp = /\)\s*(-?[\d.]+)px\s*(-?[\d.]+)px/;
var match = shadowPositionRegExp.exec(text);
var shadowXY = [parseInt(match[1]), parseInt(match[2])];
values.push(shadowXY[0]);
« no previous file with comments | « no previous file | LayoutTests/fast/sub-pixel/shadows.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698