Support subpixel values for text-shadow and box-shadow

Source/core/rendering/style/ShadowData.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 18 matching lines @@
 #include "platform/graphics/Color.h"
 
 namespace WebCore {
 
 enum ShadowStyle { Normal, Inset };
 
 // This class holds information about shadows for the text-shadow and box-shadow properties.
 class ShadowData {
     WTF_MAKE_FAST_ALLOCATED;
 public:
-    ShadowData(const IntPoint& location, int blur, int spread, ShadowStyle style, const Color& color)
+    ShadowData(const LayoutPoint& location, LayoutUnit blur, LayoutUnit spread, ShadowStyle style, const Color& color)
         : m_location(location)
         , m_blur(blur)
         , m_spread(spread)
         , m_color(color)
         , m_style(style)
     {
     }
 
     bool operator==(const ShadowData&) const;
     bool operator!=(const ShadowData& o) const { return !(*this == o); }
 
     ShadowData blend(const ShadowData& from, double progress) const;
 
-    int x() const { return m_location.x(); }
-    int y() const { return m_location.y(); }
-    IntPoint location() const { return m_location; }
-    int blur() const { return m_blur; }
-    int spread() const { return m_spread; }
+    LayoutUnit x() const { return m_location.x(); }
+    LayoutUnit y() const { return m_location.y(); }
+    LayoutPoint location() const { return m_location; }
+    LayoutUnit blur() const { return m_blur; }
+    LayoutUnit spread() const { return m_spread; }
     ShadowStyle style() const { return m_style; }
     const Color& color() const { return m_color; }
 
 private:
-    IntPoint m_location;
-    int m_blur;
-    int m_spread;
+    LayoutPoint m_location;

[Timothy Loh, 2013/12/02 07:03:10]

I don't think we store LayoutUnits/etc. in style data? Is using
FloatPoint/float/float more appropriate here (this will also probably resolve
dstockwell's concern)?

[cbiesinger, 2013/12/18 02:09:12]

Ah, looks like you're right - we store Lengths or floats.

I turned these into floats, and that did indeed solve dstockwell's issue as
well! Thanks for pointing that out!

+    LayoutUnit m_blur;
+    LayoutUnit m_spread;
     Color m_color;
     ShadowStyle m_style;
 };
 
 } // namespace WebCore
 
 #endif // ShadowData_h