Switch bot_update to use exponential backoff on clone

Switch bot_update to use exponential backoff on clone

R=iannucci@chromium.org
BUG=472386
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/c958da49797facf429100595bceb4c49e8c94cd3

[iannucci, 2016-09-09 01:33:07]

lgtm

https://codereview.chromium.org/2324073002/diff/1/recipe_modules/bot_update/r...
File recipe_modules/bot_update/resources/bot_update.py (right):

https://codereview.chromium.org/2324073002/diff/1/recipe_modules/bot_update/r...
recipe_modules/bot_update/resources/bot_update.py:549: deadline = time.time() +
5*60  # Two minutes worth of tries.
<suspicious_fry/>

https://codereview.chromium.org/2324073002/diff/1/recipe_modules/bot_update/r...
recipe_modules/bot_update/resources/bot_update.py:597: remove(sln_dir)
could this move up into the `if` clause? It clearly doesn't run in the else
case.

Actually what about
```
if <deadline_exceeded>:
  raise

# retry case
```

[agable, 2016-09-09 01:40:02]

https://codereview.chromium.org/2324073002/diff/1/recipe_modules/bot_update/r...
File recipe_modules/bot_update/resources/bot_update.py (right):

https://codereview.chromium.org/2324073002/diff/1/recipe_modules/bot_update/r...
recipe_modules/bot_update/resources/bot_update.py:549: deadline = time.time() +
5*60  # Two minutes worth of tries.
On 2016/09/09 at 01:33:07, iannucci wrote:
> <suspicious_fry/>

lol whoops. Fixed, and changed to 1 minute because geronimooooo

https://codereview.chromium.org/2324073002/diff/1/recipe_modules/bot_update/r...
recipe_modules/bot_update/resources/bot_update.py:597: remove(sln_dir)
On 2016/09/09 at 01:33:07, iannucci wrote:
> could this move up into the `if` clause? It clearly doesn't run in the else
case.
> 
> Actually what about
> ```
> if <deadline_exceeded>:
>   raise
> 
> # retry case
> ```

Good call, done.

[agable, 2016-09-09 01:41:11]

The CQ bit was checked by agable@chromium.org

[agable, 2016-09-09 01:41:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2324073002/#ps20001
(title: "A little cleaner")

[commit-bot: I haz the power, 2016-09-09 01:41:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 01:44:17]

Description was changed from

==========
Switch bot_update to use exponential backoff on clone

R=iannucci@chromium.org
BUG=472386
==========

to

==========
Switch bot_update to use exponential backoff on clone

R=iannucci@chromium.org
BUG=472386

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/c958da49797fac...
==========

[commit-bot: I haz the power, 2016-09-09 01:44:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/c958da49797fac...