Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2324033004: Fix "More than one command on the same line" presubmit errors: core/fetch,loader (Closed)

Created:
4 years, 3 months ago by hiroshige
Modified:
4 years, 3 months ago
Reviewers:
yhirano
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix "More than one command on the same line" presubmit errors: core/fetch,loader This CL fixes presubmit errors in core/fetch and core/loader: More than one command on the same line [whitespace/newline] Style fix only. BUG=645395 Committed: https://crrev.com/1f8df031140d9a63f3d3b7932b79fd4de1391b8d Cr-Commit-Position: refs/heads/master@{#418206}

Patch Set 1 #

Patch Set 2 : decreasePreloadCount() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M third_party/WebKit/Source/core/fetch/FetchUtils.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ProgressTracker.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
hiroshige
PTAL.
4 years, 3 months ago (2016-09-09 09:17:30 UTC) #2
yhirano
lgtm
4 years, 3 months ago (2016-09-12 03:53:11 UTC) #3
yhirano
On 2016/09/12 03:53:11, yhirano (slow) wrote: > lgtm Resource::decreasePreloadCount should be fixed.
4 years, 3 months ago (2016-09-12 04:16:51 UTC) #4
hiroshige
On 2016/09/12 04:16:51, yhirano (slow) wrote: > On 2016/09/12 03:53:11, yhirano (slow) wrote: > > ...
4 years, 3 months ago (2016-09-13 07:43:49 UTC) #6
yhirano
On 2016/09/13 07:43:49, hiroshige wrote: > On 2016/09/12 04:16:51, yhirano (slow) wrote: > > On ...
4 years, 3 months ago (2016-09-13 07:45:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324033004/20001
4 years, 3 months ago (2016-09-13 08:37:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-13 09:25:19 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 09:26:53 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f8df031140d9a63f3d3b7932b79fd4de1391b8d
Cr-Commit-Position: refs/heads/master@{#418206}

Powered by Google App Engine
This is Rietveld 408576698