Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2324023002: Replace try/fail/catch for EvaluationException with expect(throws). (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace try/fail/catch for EvaluationException with expect(throws). R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cfb75bfbbdd7f2a288bf73969d5eecddb1d77723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -123 lines) Patch
M pkg/analyzer/test/src/dart/constant/value_test.dart View 34 chunks +86 lines, -123 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-08 23:19:09 UTC) #1
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-09-09 00:18:53 UTC) #2
scheglov
4 years, 3 months ago (2016-09-09 00:42:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cfb75bfbbdd7f2a288bf73969d5eecddb1d77723 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698