Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2324013002: [cleanup] Remove dead code for handling pre-desugaring spread implementation (Closed)

Created:
4 years, 3 months ago by adamk
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Remove dead code for handling pre-desugaring spread implementation The array spread operator is now handled by desugaring in the parser. Committed: https://crrev.com/ca7eaa30a1856951ad10e79910e6b2bff273022e Cr-Commit-Position: refs/heads/master@{#39317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -231 lines) Patch
M src/ast/ast.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +2 lines, -22 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +1 line, -23 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
adamk
4 years, 3 months ago (2016-09-08 23:02:18 UTC) #2
Benedikt Meurer
LGTM.
4 years, 3 months ago (2016-09-09 03:39:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324013002/1
4 years, 3 months ago (2016-09-09 17:29:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 17:32:17 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 17:32:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca7eaa30a1856951ad10e79910e6b2bff273022e
Cr-Commit-Position: refs/heads/master@{#39317}

Powered by Google App Engine
This is Rietveld 408576698