extensions/browser/script_executor.cc - Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/script_executor.cc

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)

Patch Set: Less explosions Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/script_executor.cc

diff --git a/extensions/browser/script_executor.cc b/extensions/browser/script_executor.cc

index 230bca3b3f885b2dae5fcfd6731d4402141536af..28d5a773c4592017d4dbb8fb5a00ba152514ce3e 100644

--- a/extensions/browser/script_executor.cc

+++ b/extensions/browser/script_executor.cc

@@ -143,7 +143,7 @@ class Handler : public content::WebContentsObserver {

if (is_root_frame && !results_.empty())

CHECK(results_.Insert(0u, script_value->DeepCopy()));

else

- results_.Append(script_value->DeepCopy());

+ results_.Append(script_value->CreateDeepCopy());

}

if (is_root_frame) { // Only use the root frame's error and url.