extensions/browser/api/networking_private/networking_private_linux.cc - Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_linux.cc

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)

Patch Set: Less explosions Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/menu_manager.cc ('K') | « chrome/browser/extensions/window_controller.h ('k') | extensions/browser/api/printer_provider/printer_provider_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_linux.cc

diff --git a/extensions/browser/api/networking_private/networking_private_linux.cc b/extensions/browser/api/networking_private/networking_private_linux.cc

index 207a08ed571b8b29f4054376ba273454af785c7a..2b8ccd7cd9b4dfdbe388df7277100b4d77427320 100644

--- a/extensions/browser/api/networking_private/networking_private_linux.cc

+++ b/extensions/browser/api/networking_private/networking_private_linux.cc

@@ -83,7 +83,7 @@ std::unique_ptr<base::ListValue> CopyNetworkMapToList(

std::unique_ptr<base::ListValue> network_list(new base::ListValue);

for (const auto& network : network_map) {

- network_list->Append(network.second->DeepCopy());

+ network_list->Append(network.second->CreateDeepCopy());

}

return network_list;