Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Unified Diff: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)
Patch Set: ... I hate C++ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
diff --git a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
index b9f5212178edf2ef86a5dd6a3431d665c6b96c54..4504d3c9240b589ec4bd5e939b579b3891d281ad 100644
--- a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
+++ b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h"
+#include <memory>
#include <utility>
#include "base/lazy_instance.h"
@@ -119,14 +120,14 @@ void ScreenlockPrivateEventRouter::OnScreenDidLock(
proximity_auth::ScreenlockBridge::LockHandler::ScreenType screen_type) {
DispatchEvent(events::SCREENLOCK_PRIVATE_ON_CHANGED,
screenlock::OnChanged::kEventName,
- new base::FundamentalValue(true));
+ base::MakeUnique<base::FundamentalValue>(true));
}
void ScreenlockPrivateEventRouter::OnScreenDidUnlock(
proximity_auth::ScreenlockBridge::LockHandler::ScreenType screen_type) {
DispatchEvent(events::SCREENLOCK_PRIVATE_ON_CHANGED,
screenlock::OnChanged::kEventName,
- new base::FundamentalValue(false));
+ base::MakeUnique<base::FundamentalValue>(false));
}
void ScreenlockPrivateEventRouter::OnFocusedUserChanged(
@@ -135,10 +136,10 @@ void ScreenlockPrivateEventRouter::OnFocusedUserChanged(
void ScreenlockPrivateEventRouter::DispatchEvent(
events::HistogramValue histogram_value,
const std::string& event_name,
- base::Value* arg) {
+ std::unique_ptr<base::Value> arg) {
std::unique_ptr<base::ListValue> args(new base::ListValue());
if (arg)
- args->Append(arg);
+ args->Append(std::move(arg));
std::unique_ptr<Event> event(
new Event(histogram_value, event_name, std::move(args)));
EventRouter::Get(browser_context_)->BroadcastEvent(std::move(event));

Powered by Google App Engine
This is Rietveld 408576698