Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2323993003: Update blimp documentation to refer to Chrome (Closed)

Created:
4 years, 3 months ago by nyquist
Modified:
4 years, 3 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update blimp documentation to refer to Chrome Up until now the blimp client code has only been living in the //blimp directory, but now there is support for using the embedder from //chrome. This CL updates the documentation to refer to using the Chrome Public APK instead of Blimp APK in most places, and also updates the client-engine integration test script. It also updates some outdated documentation about markdown and testing in general. BUG=597756 Committed: https://crrev.com/f9cac06118524ba27ae66bb060b614a199426ce0 Cr-Commit-Position: refs/heads/master@{#418087}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Addressed comments and always refer to chrome_public_apk_incremental #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -35 lines) Patch
M blimp/docs/build.md View 1 1 chunk +4 lines, -4 lines 0 comments Download
M blimp/docs/markdown.md View 1 chunk +5 lines, -0 lines 0 comments Download
M blimp/docs/running.md View 1 4 chunks +33 lines, -18 lines 0 comments Download
M blimp/docs/test.md View 2 chunks +28 lines, -5 lines 0 comments Download
M blimp/tools/client_engine_integration.py View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
nyquist
dtrainor: PTAL
4 years, 3 months ago (2016-09-09 16:54:46 UTC) #2
David Trainor- moved to gerrit
lgtm % comments. Thanks! https://codereview.chromium.org/2323993003/diff/1/blimp/docs/build.md File blimp/docs/build.md (right): https://codereview.chromium.org/2323993003/diff/1/blimp/docs/build.md#newcode58 blimp/docs/build.md:58: ninja -C out-android/Debug blimp && ...
4 years, 3 months ago (2016-09-09 18:32:39 UTC) #3
nyquist
https://codereview.chromium.org/2323993003/diff/1/blimp/docs/build.md File blimp/docs/build.md (right): https://codereview.chromium.org/2323993003/diff/1/blimp/docs/build.md#newcode58 blimp/docs/build.md:58: ninja -C out-android/Debug blimp && \ On 2016/09/09 18:32:38, ...
4 years, 3 months ago (2016-09-12 22:00:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323993003/40001
4 years, 3 months ago (2016-09-12 22:01:41 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-12 22:52:42 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 22:55:09 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f9cac06118524ba27ae66bb060b614a199426ce0
Cr-Commit-Position: refs/heads/master@{#418087}

Powered by Google App Engine
This is Rietveld 408576698