Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1737)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java

Issue 2323993002: Mark flaky content tests with @RetryOnFailure (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java
index cdec28bffb23d2efede2fb32796291b5f0b10497..e1c4e236af134b09553ed1a37204dec1a4c74dca 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java
@@ -9,6 +9,7 @@ import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.content_public.browser.JavaScriptCallback;
import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.content_public.browser.NavigationController;
@@ -116,6 +117,7 @@ public class JavaBridgeChildFrameTest extends JavaBridgeTestBase {
// of them gets removed.
@SmallTest
@Feature({"AndroidWebView", "Android-JavaBridge"})
+ @RetryOnFailure
public void testRemovingTransientObjectHolders() throws Throwable {
class Test {
private Object mInner = new Object();
@@ -174,6 +176,7 @@ public class JavaBridgeChildFrameTest extends JavaBridgeTestBase {
@SmallTest
@Feature({"AndroidWebView", "Android-JavaBridge"})
@CommandLineFlags.Add("js-flags=--expose-gc")
+ @RetryOnFailure
public void testHolderFrame() throws Throwable {
class Test {
WeakReference<Object> mWeakRefForInner;

Powered by Google App Engine
This is Rietveld 408576698