Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2323983003: DO NOT SUBMIT: Bundle IME-related messages into one for batch edit (Closed)
Patch Set: fixed nits and fixed blimp test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 9eb70c2015db56c96005de550ad465a867b40702..a1dd3279848586ca02951b11281f2a0b70f91ddf 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -1221,53 +1221,6 @@ void WebLocalFrameImpl::moveCaretSelection(const WebPoint& pointInViewport)
frame()->selection().moveTo(position, UserTriggered);
}
-bool WebLocalFrameImpl::setEditableSelectionOffsets(int start, int end)
-{
- TRACE_EVENT0("blink", "WebLocalFrameImpl::setEditableSelectionOffsets");
-
- // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. See http://crbug.com/590369 for more details.
- frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
-
- return frame()->inputMethodController().setEditableSelectionOffsets(PlainTextRange(start, end));
-}
-
-bool WebLocalFrameImpl::setCompositionFromExistingText(int compositionStart, int compositionEnd, const WebVector<WebCompositionUnderline>& underlines)
-{
- TRACE_EVENT0("blink", "WebLocalFrameImpl::setCompositionFromExistingText");
- if (!frame()->editor().canEdit())
- return false;
-
- InputMethodController& inputMethodController = frame()->inputMethodController();
- inputMethodController.cancelComposition();
-
- if (compositionStart == compositionEnd)
- return true;
-
- // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. See http://crbug.com/590369 for more details.
- frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
-
- inputMethodController.setCompositionFromExistingText(CompositionUnderlineVectorBuilder(underlines), compositionStart, compositionEnd);
-
- return true;
-}
-
-void WebLocalFrameImpl::extendSelectionAndDelete(int before, int after)
-{
- TRACE_EVENT0("blink", "WebLocalFrameImpl::extendSelectionAndDelete");
- if (WebPlugin* plugin = focusedPluginIfInputMethodSupported()) {
- plugin->extendSelectionAndDelete(before, after);
- return;
- }
-
- // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. See http://crbug.com/590369 for more details.
- frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
-
- frame()->inputMethodController().extendSelectionAndDelete(before, after);
-}
-
void WebLocalFrameImpl::setCaretVisible(bool visible)
{
frame()->selection().setCaretVisible(visible);
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698