Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2323983003: DO NOT SUBMIT: Bundle IME-related messages into one for batch edit (Closed)
Patch Set: fixed nits and fixed blimp test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index f9d0eaa00441bd7fc87a7a223e37e880342bac11..38d7e88cdea94e4410811a8b77077c1c58cfc9ac 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1481,12 +1481,6 @@ bool RenderFrameImpl::OnMessageReceived(const IPC::Message& msg) {
IPC_MESSAGE_HANDLER(InputMsg_ReplaceMisspelling, OnReplaceMisspelling)
IPC_MESSAGE_HANDLER(FrameMsg_CopyImageAt, OnCopyImageAt)
IPC_MESSAGE_HANDLER(FrameMsg_SaveImageAt, OnSaveImageAt)
- IPC_MESSAGE_HANDLER(InputMsg_ExtendSelectionAndDelete,
- OnExtendSelectionAndDelete)
- IPC_MESSAGE_HANDLER(InputMsg_SetCompositionFromExistingText,
- OnSetCompositionFromExistingText)
- IPC_MESSAGE_HANDLER(InputMsg_SetEditableSelectionOffsets,
- OnSetEditableSelectionOffsets)
IPC_MESSAGE_HANDLER(InputMsg_ExecuteNoValueEditCommand,
OnExecuteNoValueEditCommand)
IPC_MESSAGE_HANDLER(FrameMsg_AddMessageToConsole, OnAddMessageToConsole)
@@ -2016,35 +2010,10 @@ void RenderFrameImpl::OnVisualStateRequest(uint64_t id) {
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE);
}
-void RenderFrameImpl::OnSetEditableSelectionOffsets(int start, int end) {
- base::AutoReset<bool> handling_select_range(&handling_select_range_, true);
- if (!GetRenderWidget()->ShouldHandleImeEvent())
- return;
- ImeEventGuard guard(GetRenderWidget());
- frame_->setEditableSelectionOffsets(start, end);
-}
-
-void RenderFrameImpl::OnSetCompositionFromExistingText(
- int start, int end,
- const std::vector<blink::WebCompositionUnderline>& underlines) {
- if (!GetRenderWidget()->ShouldHandleImeEvent())
- return;
- ImeEventGuard guard(GetRenderWidget());
- frame_->setCompositionFromExistingText(start, end, underlines);
-}
-
void RenderFrameImpl::OnExecuteNoValueEditCommand(const std::string& name) {
frame_->executeCommand(WebString::fromUTF8(name));
}
-void RenderFrameImpl::OnExtendSelectionAndDelete(int before, int after) {
- if (!GetRenderWidget()->ShouldHandleImeEvent())
- return;
-
- ImeEventGuard guard(GetRenderWidget());
- frame_->extendSelectionAndDelete(before, after);
-}
-
void RenderFrameImpl::OnSetAccessibilityMode(AccessibilityMode new_mode) {
if (accessibility_mode_ == new_mode)
return;
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698