Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: content/common/input_messages.h

Issue 2323983003: DO NOT SUBMIT: Bundle IME-related messages into one for batch edit (Closed)
Patch Set: fixed nits and fixed blimp test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/input_messages.h
diff --git a/content/common/input_messages.h b/content/common/input_messages.h
index a602eb56840f62b39a524522538045e4ddd49743..33a83c56a89ee7d2faef4eafe5c4e0067b1e1057 100644
--- a/content/common/input_messages.h
+++ b/content/common/input_messages.h
@@ -140,20 +140,20 @@ IPC_MESSAGE_ROUTED1(InputMsg_CursorVisibilityChange,
// Sets the text composition to be between the given start and end offsets in
// the currently focused editable field.
-IPC_MESSAGE_ROUTED3(InputMsg_SetCompositionFromExistingText,
+IPC_MESSAGE_ROUTED3(InputMsg_ImeSetCompositionFromExistingText,
int /* start */,
int /* end */,
std::vector<blink::WebCompositionUnderline> /* underlines */)
// Deletes the current selection plus the specified number of characters before
// and after the selection or caret.
-IPC_MESSAGE_ROUTED2(InputMsg_ExtendSelectionAndDelete,
+IPC_MESSAGE_ROUTED2(InputMsg_ImeExtendSelectionAndDelete,
int /* before */,
int /* after */)
// Selects between the given start and end offsets in the currently focused
// editable field.
-IPC_MESSAGE_ROUTED2(InputMsg_SetEditableSelectionOffsets,
+IPC_MESSAGE_ROUTED2(InputMsg_ImeSetEditableSelectionOffsets,
int /* start */,
int /* end */)
@@ -172,6 +172,10 @@ IPC_MESSAGE_ROUTED3(InputMsg_ImeConfirmComposition,
gfx::Range /* replacement_range */,
bool /* keep_selection */)
+// Sends a list of IME-related messages to be executed at once as a batch.
+IPC_MESSAGE_ROUTED1(InputMsg_ImeBatchEdit,
+ std::vector<IPC::Message> /* messages */)
+
// This message notifies the renderer that the next key event is bound to one
// or more pre-defined edit commands. If the next key event is not handled
// by webkit, the specified edit commands shall be executed against current
@@ -259,11 +263,11 @@ IPC_MESSAGE_ROUTED1(InputMsg_MoveCaret,
IPC_MESSAGE_ROUTED0(InputMsg_ImeEventAck)
// Request from browser to update text input state.
-IPC_MESSAGE_ROUTED0(InputMsg_RequestTextInputStateUpdate)
+IPC_MESSAGE_ROUTED0(InputMsg_ImeRequestTextInputStateUpdate)
#endif
// Request from browser to update the cursor and composition information.
-IPC_MESSAGE_ROUTED2(InputMsg_RequestCompositionUpdate,
+IPC_MESSAGE_ROUTED2(InputMsg_ImeRequestCompositionUpdate,
bool /* immediate request */,
bool /* monitor request */)

Powered by Google App Engine
This is Rietveld 408576698